Skip to content

Simplify PreferredConstructorDiscovererUnitTests #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Simplify PreferredConstructorDiscovererUnitTests #2724

wants to merge 3 commits into from

Conversation

An1s9n
Copy link

@An1s9n An1s9n commented Oct 22, 2022

Hello, team!

This pull request is my attempt to help you to close #2695 issue.

Hope it will help you :)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 22, 2022
gregturn pushed a commit that referenced this pull request Apr 24, 2023
@gregturn
Simplify PreferredConstructorDiscovererUnitTests.
ccd56ef 
Leverage things like Java var keyword to simplify test cases.

Resolves #2695.
Related: #2694.
Original pull request: #2724.
@gregturn gregturn closed this Apr 24, 2023
@gregturn
Copy link
Contributor

Thanks @An1s9n. We took your rewritten test cases, but decided to keep that annotations as they were.

@gregturn gregturn removed the status: waiting-for-triage An issue we've not yet triaged label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gregturn gregturn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite PreferredConstructorDiscovererUnitTests to not use inner asserts but regular ones
3 participants
@An1s9n @gregturn @spring-projects-issues