Skip to content

bug fix when using kotlin value class #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sangyongchoi
Copy link

Hi, i am spring data mongo user.
I experienced bug when using spring data mongo with kotlin value class.
You can see it in this repository.

Classes with "Kotlin value class" as members have private constructors when compiled.
Then, a constructor is created with the DefaultConstructorMarker added.
I think it's the cause of the bug.

Since the DefaultConstructorMarker does nothing, I think return it to null will solve the problem.
Could you consider this?

Thank you 😄

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 5, 2022
@sangyongchoi sangyongchoi reopened this Oct 5, 2022
@sangyongchoi sangyongchoi reopened this Oct 7, 2022
@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 24, 2023
@mp911de
Copy link
Member

mp911de commented Apr 24, 2023

Thanks for looking into value/inline classes. This is a broader topic that requires much more changes. Please have a look at #2806 and #1947.

@mp911de mp911de closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants