Extension special types (Pageable and Sort) to subtypes (e.g. PageRequest, etc.) #2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring Data Commons has a hard-coded list of special types than can be included in query methods including Pageable and Sort. A custom finder with PageRequest, even though it extends Pageable, will fail when it would work fine with a narrowed input. This extends the list using an isAssignableFrom check. Related: spring-projects/spring-data-jpa#2013 See #2626.
mp911de
reviewed
May 12, 2022
| * @param parameterType | ||
| * @return boolean | ||
| */ | ||
| private static boolean isSpecialParameterType(Class<?> parameterType) { |
There was a problem hiding this comment.
We should refrain from using Java 8 Streams due to performance reasons.
|
That's polished and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone defines a custom finder using a subtype, like
findByLastname(String lastname, PageRequest page), Spring Data Commons will fail to properly handle it, since it has a strict members-only policy for special types.This list should be extended to subclasses so a custom finder using any of these subtypes will also work.
Closes #2626.