Introduce common AOT infrastructure. #2624
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxblum
reviewed
May 5, 2022
| /** | ||
| * @author Christoph Strobl | ||
| */ | ||
| public class TypeUtils { |
There was a problem hiding this comment.
Perhaps this class can be moved to org.springframework.data.util.
I don't see anything in this class that is specific to the native AOT processing infrastructure classes in Spring Data (i.e. org.springframework.data.aot).
jxblum
reviewed
May 5, 2022
| return types::forEach; | ||
| } | ||
|
|
||
| static ManagedTypes o(Supplier<Iterable<? extends Class<?>>> dataProvider) { |
There was a problem hiding this comment.
Misspelled. No matter, I fixed in a polish commit.
jxblum
reviewed
May 5, 2022
| }; | ||
|
|
||
| public TypeCollector filterFields(Predicate<Field> filter) { | ||
| this.fieldFilter = filter.and(filter); |
There was a problem hiding this comment.
Just curious if you meant to prepend here? I ask because the filterTypes(:Predicate) method below "appends".
jxblum
reviewed
May 5, 2022
|
|
||
| static class InspectionCache { | ||
|
|
||
| private final Map<String, ResolvableType> mutableCache = new LinkedHashMap<>(); |
jxblum
force-pushed
the
issue/2593
branch
7 times, most recently
from
2c4e594 to
5dd1edc
Compare
christophstrobl
force-pushed
the
issue/2593
branch
from
df1cfca to
175ed04
Compare
odrotbohm
force-pushed
the
main
branch
2 times, most recently
from
c08d207 to
2a1a8f3
Compare
christophstrobl
force-pushed
the
issue/2593
branch
2 times, most recently
from
80cea59 to
ecd5f79
Compare
christophstrobl
force-pushed
the
issue/2593
branch
from
dd7290f to
1b9e17f
Compare
This commit introduces initial support for framework 6 bases ahead of time processing of data components and adds extension points for module implementations.
Should be dropped on merge!
We provide an initial set of runtime hints required to spin up data repositories on GraalVM native image.
…ections. We now provide PropertiesBasedNamedQueriesFactoryBean to create PropertiesBasedNamedQueries directly bypassing indirections through PropertiesFactoryBean and PropertiesBasedNamedQueries.
…anDefinition(…) to allow additional bean registrations.
This avoids having to touch modules to add something like ImportRuntimeHints(AuditingHints.ReactiveAuditingRuntimeHints.class) to the enabled auditing annotations.
Simplify field and method filter creation. Reformat aot.factories.
Enables reachability analysis. Previously, the presence checks were using method invocations and the AOT processing isn't following the methods.
Improve factory methods. Integrate auditing hints in AuditingBeanRegistrationAotProcessor. Reduce visibility, improve naming.
christophstrobl
force-pushed
the
issue/2593
branch
from
01b58a3 to
f9033cf
Compare
christophstrobl
pushed a commit
that referenced
this pull request
Jul 4, 2022
* Refactored logic in AOT infrastructure classes. * Annotated AOT API with Spring's @nonnull and @nullable annotations. * Edited Javadoc. * Introduced PredicateUtils abstract utility class encapsulating common Predicates on types and class members. * Added comments for review and clarification. Original Pull Request: #2624
christophstrobl
added a commit
that referenced
this pull request
Jul 4, 2022
We provide an initial set of runtime hints required to spin up data repositories on GraalVM native image. Additionally we skip synthetic types during type inspection. Original Pull Request: #2624
christophstrobl
pushed a commit
that referenced
this pull request
Jul 4, 2022
…ections. We now provide PropertiesBasedNamedQueriesFactoryBean to create PropertiesBasedNamedQueries directly bypassing indirections through PropertiesFactoryBean and PropertiesBasedNamedQueries. Original Pull Request: #2624
christophstrobl
added a commit
that referenced
this pull request
Jul 4, 2022
Original Pull Request: #2624
christophstrobl
pushed a commit
that referenced
this pull request
Jul 4, 2022
…anDefinition(…) to allow additional bean registrations. Original Pull Request: #2624
christophstrobl
added a commit
that referenced
this pull request
Jul 4, 2022
This avoids having to touch modules to add something like ImportRuntimeHints(AuditingHints.ReactiveAuditingRuntimeHints.class) to the enabled auditing annotations. Original Pull Request: #2624
christophstrobl
pushed a commit
that referenced
this pull request
Jul 4, 2022
Update javadoc and reformat aot.factories. Original Pull Request: #2624
christophstrobl
pushed a commit
that referenced
this pull request
Jul 4, 2022
Enables reachability analysis. Previously, the presence checks were using method invocations and the AOT processing isn't following the methods. Original Pull Request: #2624
christophstrobl
pushed a commit
that referenced
this pull request
Jul 4, 2022
Original Pull Request: #2624
christophstrobl
pushed a commit
that referenced
this pull request
Jul 4, 2022
Improve factory methods. Integrate auditing hints in AuditingBeanRegistrationAotProcessor. Reduce visibility, improve naming. Original Pull Request: #2624
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commons module hosts the basic infrastructure for contributing data related bits to the AOT processing.
We introduced
ManagedTypesas an abstraction that allows to define what was up till now defined via theinitialEntitySetin theMappingContext.ManagedTypesmay be provided per store module as a regular bean in the application context, if not present a lazy evaluating variant will be registered, picking up types annotated with one of the store specificidentifyingAnnotationswithin the repository base packages.This allows store implementations to provide an
AotManagedTypesPostProcessorpicking up the bean to render additional configuration (reflection, proxy,...) for the domain types present.RepositoryConfigurationExtension.getAotPostProcessor()defines the type of theAotContributingRepositoryBeanPostProcessorto be used by a store module. By default the variant provided by data commons will contribute proxy/reflection configuration for all types reachable from the repository interface. This includes the domain & id types as well as those returned by repository finder methods identifying potential projection proxies.