Skip to content

Fix Javadoc in QueryByExampleExecutor #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alikilickaya
Copy link
Contributor

What

Fixing the Javadoc of QueryByExampleExecutor.findOne(Example<S> example).

Why

QueryByExampleExecutor.findOne(Example<S> example) doesn't return null if none was found. It returns Optional.empty().

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 12, 2021
mp911de pushed a commit that referenced this pull request Oct 13, 2021
@mp911de mp911de closed this in dd8a808 Oct 13, 2021
mp911de pushed a commit that referenced this pull request Oct 13, 2021
@mp911de mp911de added this to the 2.4.14 (2020.0.14) milestone Oct 13, 2021
@mp911de
Copy link
Member

mp911de commented Oct 13, 2021

Thank you for your contribution. That's merged and backported now.

@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants