Fix typo in entity state detection documentation #2416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schlagi123
commented
Jul 17, 2021
•
schlagi123
commented
- You have read the Spring Data contribution guidelines.
- You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
- You submit test cases (unit or integration tests) that back your changes. (asciidoc only)
- You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only). (asciidoc only)
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
reviewed
Jul 20, 2021
| |By default, Spring Data inspects the version property of the given entity. | ||
| If the identifier property is `null` or `0` in case of primitive types, then the entity is assumed to be new. | ||
| |By default, Spring Data inspects the id property of the given entity. | ||
| If the id property is `null` or `0` in case of primitive types, then the entity is assumed to be new. |
There was a problem hiding this comment.
Any reason you're changing identifier into id in random places?
There was a problem hiding this comment.
In some places in the text there is Id, in other places there is an identifier. I thought I would unify it in this section. I don't care whether it's id or identifier, I just thought id is closer to @Id annotation than identifier.
mp911de
changed the title
mp911de
added
type: documentation
mp911de
pushed a commit
that referenced
this pull request
Sep 7, 2021
mp911de
pushed a commit
that referenced
this pull request
Sep 7, 2021
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.