Skip to content

Fix wrong example code #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix wrong example code #2391

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jun 24, 2021

  1. Add missing s in @RequiredArgsConstructor
  2. Add final modifier to mark field as required

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 24, 2021
mp911de pushed a commit that referenced this pull request Jul 12, 2021
@quaff @mp911de
Fix code example showing Streamable usage.
d4e7205 
Closes #2391
@mp911de mp911de closed this in 7e1c345 Jul 12, 2021
mp911de pushed a commit that referenced this pull request Jul 12, 2021
@quaff @mp911de
Fix code example showing Streamable usage.
7d0b9ad 
Closes #2391
mp911de pushed a commit that referenced this pull request Jul 12, 2021
@quaff @mp911de
Fix code example showing Streamable usage.
3c5cf34 
Closes #2391
@mp911de
Copy link
Member

mp911de commented Jul 12, 2021

Good catch. Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 12, 2021
@mp911de mp911de self-assigned this Jul 12, 2021
@mp911de mp911de added this to the 2.3.10 (Neumann SR10) milestone Jul 12, 2021
@mp911de mp911de mentioned this pull request Jul 12, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.3.10 (Neumann SR10)
Development

Successfully merging this pull request may close these issues.
3 participants
@quaff @mp911de @spring-projects-issues