Skip to content

Look up bean definitions using merge strategy #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GnusinPavel
Copy link

@GnusinPavel GnusinPavel commented Jun 16, 2021

closes #2383

@pivotal-cla
Copy link

@GnusinPavel Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 16, 2021
@GnusinPavel GnusinPavel changed the title #2383 Look up bean definitions using merge strategy. re #2383 Look up bean definitions using merge strategy. Jun 16, 2021
@GnusinPavel GnusinPavel changed the title re #2383 Look up bean definitions using merge strategy. #2383 Look up bean definitions using merge strategy. Jun 16, 2021
@pivotal-cla
Copy link

@GnusinPavel Thank you for signing the Contributor License Agreement!

@mp911de mp911de changed the title #2383 Look up bean definitions using merge strategy. Look up bean definitions using merge strategy Oct 12, 2021
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 12, 2021
@mp911de mp911de added this to the 2.5.6 (2021.0.6) milestone Oct 12, 2021
mp911de pushed a commit that referenced this pull request Oct 12, 2021
We now look up bean definitions for repositories using BeanFactory.getMergedBeanDefinition(…) to consider parent-child relationships across application contexts.

As we iterate through bean definitions considering ancestors we need to allow parent bean definitions. Previously, we obtained the bean definition from the child context and since the bean was inherited from the parent, the child context cannot provide a bean definition.

Closes #2383
Original pull request: #2384.
mp911de pushed a commit that referenced this pull request Oct 12, 2021
We now look up bean definitions for repositories using BeanFactory.getMergedBeanDefinition(…) to consider parent-child relationships across application contexts.

As we iterate through bean definitions considering ancestors we need to allow parent bean definitions. Previously, we obtained the bean definition from the child context and since the bean was inherited from the parent, the child context cannot provide a bean definition.

Closes #2383
Original pull request: #2384.
@mp911de
Copy link
Member

mp911de commented Oct 12, 2021

Thank you for your contribution. That's merged and backported now.

@mp911de mp911de closed this Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
4 participants