DATACMNS-1067 - Fix not to call @AfterDomainEventPublication method from Collection of entities. #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom Collection of entities.
|
One thing I am kind of puzzled about is the mismatch between the fix and the description in the original ticket. The ticket claims a problem with |
|
I think I got it. The essential fix referring to the ticket is that the object that the clearing method is invoked on is the aggregate root, not the parameter object. However, I am now unsure about the change to only clear the events if they have been exposed. This is a feature we can discuss, but it's not something I would want to couple with the fix for the issue described in the ticket. |
|
Yes, we should call |
|
Thanks for clarifying. Already at it :). |
odrotbohm
pushed a commit
that referenced
this pull request
May 15, 2017
…rom collection of entities. We now make sure the event cleanup method is called on the aggregate root, not on the parameter object directly (as the latter might be a collection. Original pull request: #216.
odrotbohm
added a commit
that referenced
this pull request
May 15, 2017
Revert change to only invoke cleanup method if events have been exposed. We now again invoke the cleanup method for every aggregate. Changed the publication of events from the aggregate instances that were handed into the method to the ones the save method returns as the save call might return different object instances. Cleanups in the unit tests. Moved newly introduced methods to the bottom of the test case class. Extracted method to set up mock method invocation. Original pull request: #216.
odrotbohm
pushed a commit
that referenced
this pull request
May 15, 2017
…rom collection of entities. We now make sure the event cleanup method is called on the aggregate root, not on the parameter object directly (as the latter might be a collection. Original pull request: #216.
odrotbohm
added a commit
that referenced
this pull request
May 15, 2017
Revert change to only invoke cleanup method if events have been exposed. We now again invoke the cleanup method for every aggregate. Changed the publication of events from the aggregate instances that were handed into the method to the ones the save method returns as the save call might return different object instances. Cleanups in the unit tests. Moved newly introduced methods to the bottom of the test case class. Extracted method to set up mock method invocation. Original pull request: #216.
odrotbohm
pushed a commit
that referenced
this pull request
May 15, 2017
…rom collection of entities. We now make sure the event cleanup method is called on the aggregate root, not on the parameter object directly (as the latter might be a collection. Original pull request: #216.
odrotbohm
added a commit
that referenced
this pull request
May 15, 2017
Revert change to only invoke cleanup method if events have been exposed. We now again invoke the cleanup method for every aggregate. Changed the publication of events from the aggregate instances that were handed into the method to the ones the save method returns as the save call might return different object instances. Cleanups in the unit tests. Moved newly introduced methods to the bottom of the test case class. Extracted method to set up mock method invocation. Original pull request: #216.
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
…us-codes Retry requests on specified status codes. Fixes spring-projects#215.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed below ticket, please review.
https://jira.spring.io/browse/DATACMNS-1067