DATACMNS-925 - Improve memory consumption of Parameter and Parameters. #180
Conversation
This commit changes some ArrayList initializations to use an initial capacity and avoids the unnecessary fetch of the return type of a method in Parameter.isDynamicProjectionParameter()
| List<Class<?>> types = Arrays.asList(method.getParameterTypes()); | ||
|
|
||
| this.parameters = new ArrayList<T>(types.size()); |
There was a problem hiding this comment.
Would you mind keeping the old position of the code and only add the initial sizing? Moving the code doesn't seem to have any effect here and types was declared as close to its usage (the loop below) by purpose. Or do I oversee anything?
There was a problem hiding this comment.
I need the types variable here in order to retrieve the size. If I call method.getParameters() again I have the overhead of cloning the method parameters, which I wanted to avoid. As far as I saw, you're not yet compiling against Java 8, which would have enabled me to call Method.getParameterCount().
| int pageableIndexTemp = -1; | ||
| int sortIndexTemp = -1; | ||
| int dynamicProjectionTemp = -1; | ||
|
|
||
| this.parameters = new ArrayList<T>(originals.size()); |
There was a problem hiding this comment.
The same as above. Defining an initial size for the array seems like a good idea. However, that doesn't need the code moved.
There was a problem hiding this comment.
In this case your right, this was just for "consistency" to the method above. Let me know when I should change it.
This commit changes some ArrayList initializations to use an initial capacity and avoids the unnecessary fetch of the return type of a method in Parameter.isDynamicProjectionParameter(). Original pull request: #180.
Moved an assignment back to its original place to create instance state as early as possible. Original pull request: #180.
This commit changes some ArrayList initializations to use an initial capacity and avoids the unnecessary fetch of the return type of a method in Parameter.isDynamicProjectionParameter(). Original pull request: #180.
Moved an assignment back to its original place to create instance state as early as possible. Original pull request: #180.
|
That's merged, thanks! |
Making SimpleDiscoveryClient the default, marking NoOpDiscoveryClient as deprecated fixes spring-projectsgh-180
Fixes https://jira.spring.io/browse/DATACMNS-925