DATACMNS-583 - DomainClassConverter returns input if given types are the same. #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 28, 2014 15:16
…source- and targetType are equal. Prepare issue branch.
…the same. DomainClassConverter now returns input when sourceType equals targetType. Previously we erroneously tried to convert the sourceType to the idType of the targetType's backing Repository. As a side effect we also avoid performing some unnecessary converter hops. Origial pull request: #101.
thomasdarimont
force-pushed
the
issue/DATACMNS-583
branch
from
86f8c62 to
b9900cf
Compare
thomasdarimont
pushed a commit
that referenced
this pull request
Oct 29, 2014
…the same. DomainClassConverter now returns input when the source type is identical to the target type. Previously we erroneously tried to convert the sourceType to the idType of the targetType's backing repository. As a side effect we also avoid performing some unnecessary converter hops. Original pull request: #101.
thomasdarimont
pushed a commit
that referenced
this pull request
Oct 29, 2014
…the same. DomainClassConverter now returns input when the source type is identical to the target type. Previously we erroneously tried to convert the sourceType to the idType of the targetType's backing repository. As a side effect we also avoid performing some unnecessary converter hops. Original pull request: #101.
thomasdarimont
pushed a commit
that referenced
this pull request
Oct 29, 2014
…the same. DomainClassConverter now returns input when the source type is identical to the target type. Previously we erroneously tried to convert the sourceType to the idType of the targetType's backing repository. As a side effect we also avoid performing some unnecessary converter hops. Original pull request: #101.
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DomainClassConverter now returns input when sourceType equals targetType.
Previously we erroneously tried to convert the sourceType to the idType of the targetType's backing Repository. As a side effect we also avoid performing some unnecessary converter hops.