AnnotationBasedPersistentProperty cannot resolve Id properties [Wrong Id class used]

[SledgeHammer01]

BasicPersistentEntity::returnPropertyIfBetterIdPropertyCandidateOrNull
--> AnnotationBasedPersistentProperty::isIdProperty

https://github.com/spring-projects/spring-data-commons/blob/main/src/main/java/org/springframework/data/mapping/model/AnnotationBasedPersistentProperty.java#L78-L79

Shouldn't the Id.class used here be jakarta.persistence.id?

Otherwise the RelationalEntityMetadata doesn't contain the id column.

[mp911de]

Not sure I follow. RelationalEntityMetadata is part of the Spring Data Relational module (not JPA) and thus it doesn't use the Jakarta Persistence API annotations. Care to elaborate the actual issue, ideally by providing a reproducer or code snippet to illustrate the usecase?

[SledgeHammer01]

Not sure I follow. RelationalEntityMetadata is part of the Spring Data Relational module (not JPA) and thus it doesn't use the Jakarta Persistence API annotations. Care to elaborate the actual issue, ideally by providing a reproducer or code snippet to illustrate the usecase?

I am building a Spring Boot Starter for Hibernate Reactive. So I have a HibernateReactiveQueryMethod class for string and PartTree based queries.

My getEntityInformationMethod() override looks like:

 @Override
  @SuppressWarnings("unchecked")
  public RelationalEntityMetadata<?> getEntityInformation() {
    if (this.metadata == null) {
      Class<?> returnedObjectType = getReturnedObjectType();
      Class<?> domainClass = getDomainClass();

      if (ClassUtils.isPrimitiveOrWrapper(returnedObjectType)
          || ReflectionUtils.isVoid(returnedObjectType)) {
        this.metadata =
            new SimpleRelationalEntityMetadata<>(
                (Class<Object>) domainClass,
                this.mappingContext.getRequiredPersistentEntity(domainClass));
      } else {
        RelationalPersistentEntity<?> returnedEntity =
            this.mappingContext.getPersistentEntity(returnedObjectType);

        RelationalPersistentEntity<?> managedEntity =
            this.mappingContext.getRequiredPersistentEntity(domainClass);

        returnedEntity =
            ((returnedEntity == null) || returnedEntity.getType().isInterface())
                ? managedEntity
                : returnedEntity;

        RelationalPersistentEntity<?> tableEntity =
            domainClass.isAssignableFrom(returnedObjectType) ? returnedEntity : managedEntity;

        this.metadata =
            new SimpleRelationalEntityMetadata<>(
                (Class<Object>) returnedEntity.getType(), tableEntity);
      }
    }

    return this.metadata;
  }

the entityMetadata.getTableEntity().getIdColumn() doesn't work because the entity will be using jakarta.persistence.Id, but stepping through the Spring code, it is looking for the org.springframework.data.annotation.Id.

Possible its supposed to work like that since this is internal Spring stuff, but seemed logical that getEntityInformation() should pick up the @Id column on the entity? I made that assumption since it picks up all the other stuff from the entity annotations, just not the id column.