Skip to content

Revisit the need to set FACTORY_BEAN_OBJECT_TYPE on repository bean definitions #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odrotbohm opened this issue Aug 1, 2023 · 0 comments
Closed

Revisit the need to set FACTORY_BEAN_OBJECT_TYPE on repository bean definitions #2894

odrotbohm opened this issue Aug 1, 2023 · 0 comments
Labels
in: repository Repositories abstraction type: task A general task
Milestone
3.2 M2 (2023.1.0)

Comments

@odrotbohm
Copy link
Member

IIRC, we only introduced setting the attribute to work around in a —likely fixed in the meantime — limitation in Spring Framework. As we now even need to load the repository interface to set the attribute (see #2891) we should revisit that practice to potentially be able to avoid that as we now have to load the repository interface twice. First time in RepositoryConfigurationExtensionSupport.getRepositoryConfigurations(…), unless we significantly refactor the way we create the bean definitions.
@odrotbohm odrotbohm mentioned this issue Aug 1, 2023
Closed
odrotbohm added a commit that referenced this issue Aug 2, 2023
@odrotbohm
Drop using FACTORY_BEAN_OBJECT_TYPE attribute entirely.
3d8cbe0 
We now constantly use RootBeanDefinition.setBeanClass(…) (for the raw factory type) and ….setTargetType(…) to declare the actual repository type.

Ticket: #2894.
odrotbohm added a commit that referenced this issue Aug 2, 2023
@odrotbohm
Drop using FACTORY_BEAN_OBJECT_TYPE attribute entirely.
ab02fc8 
We now constantly use RootBeanDefinition.setBeanClass(…) (for the raw factory type) and ….setTargetType(…) to declare the full repository factory type including the user defined repository, domain and identifier type.

Ticket: #2894.
odrotbohm added a commit that referenced this issue Aug 2, 2023
@odrotbohm
Drop using FACTORY_BEAN_OBJECT_TYPE attribute entirely.
fe5e80e 
We now constantly use RootBeanDefinition.setBeanClass(…) (for the raw factory type) and ….setTargetType(…) to declare the full repository factory type including the user defined repository, domain and identifier type.

Ticket: #2894.
odrotbohm added a commit that referenced this issue Aug 2, 2023
@odrotbohm
Drop using FACTORY_BEAN_OBJECT_TYPE attribute entirely.
98f20a4 
We now constantly use RootBeanDefinition.setBeanClass(…) (for the raw factory type) and ….setTargetType(…) to declare the full repository factory type including the user defined repository. Any other generics are simply filled with Object.class.

Ticket: #2894.
@mp911de mp911de added this to the 3.2 M2 (2023.1.0) milestone Aug 8, 2023
@mp911de mp911de closed this as completed Aug 8, 2023
@mp911de mp911de added type: task A general task in: repository Repositories abstraction labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: repository Repositories abstraction type: task A general task
Projects
None yet
Milestone
3.2 M2 (2023.1.0)
Development

No branches or pull requests
2 participants
@odrotbohm @mp911de