Skip to content

Adopt DefaultReactiveEntityCallbacksUnitTests to Java 18's IllegalArgumentException as marker for incompatible lambda payload #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michael-simons opened this issue Mar 31, 2023 · 1 comment
Closed

Adopt DefaultReactiveEntityCallbacksUnitTests to Java 18's IllegalArgumentException as marker for incompatible lambda payload #2808

michael-simons opened this issue Mar 31, 2023 · 1 comment
Assignees
@odrotbohm
Labels
in: core Issues in core support type: bug A general bug
Milestone
3.0.5 (2022.0.5)

Comments

@michael-simons
Copy link
Contributor

The DefaultReactiveEntityCallbacksUnitTests has not been enhanced In #2583 to capture IllegalArgumentException that are the result when a lambda-defined listener for which the generic event type for could not be resolved gets called.

This is the case of the issues in this ticket at SDN spring-projects/spring-data-neo4j#2701
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 31, 2023
@michael-simons michael-simons mentioned this issue Mar 31, 2023
Closed
4 tasks
michael-simons added a commit to michael-simons/spring-data-commons that referenced this issue Mar 31, 2023
@michael-simons
Gracefully skip non-assignable reactive lambda callbacks on Java 18+.
dd464fc 
Closes spring-projects#2808.
@odrotbohm odrotbohm removed the status: waiting-for-triage An issue we've not yet triaged label Apr 4, 2023
@odrotbohm
Copy link
Member

This is fixed by merging your PR. Note that we further improve the handling of Lambda-based EntityCallback declarations in #2812.

@odrotbohm odrotbohm added this to the 3.0.5 (2022.0.5) milestone Apr 4, 2023
@odrotbohm odrotbohm added type: bug A general bug in: core Issues in core support labels Apr 4, 2023
odrotbohm pushed a commit that referenced this issue Apr 4, 2023
@michael-simons @odrotbohm
Gracefully skip non-assignable reactive lambda callbacks on Java 18+.
ba2e0f9 
Closes #2808, #2809.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Issues in core support type: bug A general bug
Projects
None yet
Milestone
3.0.5 (2022.0.5)
3 participants
@odrotbohm @michael-simons @spring-projects-issues