-
Notifications
You must be signed in to change notification settings - Fork 682
Add default RepositoryConfigurationExtension.getModuleIdentifier()
method
#2644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Not opposed to this change, but what was just wondering what was the main motivation driving this change (now)? |
This is to split out the change so we can merge the the ManagedTypes change without the need to touch all modules. |
Ah, right. Thx, @mp911de. |
RepositoryConfigurationExtension.getModulePrefix()
methodRepositoryConfigurationExtension.getModuleIdentifier()
method
In the triage call today we came to the following, slightly different conclusion:
The introduced |
This is in place now. As indicated in 75387bb, modules are encouraged to move away from implementing |
The module prefix is being used in various places, however the implementation is only available on the abstract
RepositoryConfigurationExtensionSupport
class and not on theRepositoryConfigurationExtension
interface. We should provide a default method for easier consumption. This change requires an update of allRepositoryConfigurationExtensionSupport
implementations that define a protectedgetModulePrefix
method.The text was updated successfully, but these errors were encountered: