Skip to content

Performance improvements in ReactiveWrappers and ConvertingPropertyAccessor #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Feb 11, 2022 · 0 comments
Closed

Performance improvements in ReactiveWrappers and ConvertingPropertyAccessor #2546

mp911de opened this issue Feb 11, 2022 · 0 comments
Labels
type: enhancement A general enhancement
Milestone
2.6.2 (2021.1.2)

Comments

@mp911de
Copy link
Member

mp911de commented Feb 11, 2022 •
edited
Loading

ReactiveWrappers.isAvailable() performs repetitive checks on classpath availability and supports(…) could cache the outcome on a per-type basis to avoid looping through the registry.

ConvertingPropertyAccessor.convertIfNecessary(…) should avoid calling the conversion service if the target type is a primitive by using ClassUtils.resolvePrimitiveIfNecessary(type).

Findings originate from spring-projects/spring-data-cassandra#1218.
@mp911de mp911de added the type: enhancement A general enhancement label Feb 11, 2022
@mp911de mp911de added this to the 2.6.2 (2021.1.2) milestone Feb 11, 2022
mp911de added a commit that referenced this issue Feb 11, 2022
@mp911de
Performance improvements in ReactiveWrappers and `ConvertingPropert…
68bfa9a 
…yAccessor`.

We now cache whether types are reactive wrappers and bypass the ConversionService for assignable primitive values.

Closes #2546
mp911de added a commit that referenced this issue Feb 11, 2022
@mp911de
Performance improvements in ReactiveWrappers and `ConvertingPropert…
20f440a 
…yAccessor`.

We now cache whether types are reactive wrappers and bypass the ConversionService for assignable primitive values.

Closes #2546
odrotbohm added a commit that referenced this issue Feb 14, 2022
@odrotbohm
Simpler check to avoid primitive conversion in ConvertingPropertyAcce…
abbc648 
…ssor.

We now use Spring's ClassUtils.isAssignable(…) directly. Unit tests to verify that conversion is skipped for primitive / boxed scenarios.

See #2546.
odrotbohm added a commit that referenced this issue Feb 14, 2022
@odrotbohm
Simpler check to avoid primitive conversion in ConvertingPropertyAcce…
44a472c 
…ssor.

We now use Spring's ClassUtils.isAssignable(…) directly. Unit tests to verify that conversion is skipped for primitive / boxed scenarios.

See #2546.
mp911de pushed a commit that referenced this issue Feb 17, 2022
@odrotbohm @mp911de
Simpler check to avoid primitive conversion in ConvertingPropertyAcce…
3ec4063 
…ssor.

We now use Spring's ClassUtils.isAssignable(…) directly. Unit tests to verify that conversion is skipped for primitive / boxed scenarios.

See #2546.
mp911de pushed a commit that referenced this issue Feb 17, 2022
@odrotbohm @mp911de
Simpler check to avoid primitive conversion in ConvertingPropertyAcce…
92d8de0 
…ssor.

We now use Spring's ClassUtils.isAssignable(…) directly. Unit tests to verify that conversion is skipped for primitive / boxed scenarios.

See #2546.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.6.2 (2021.1.2)
Development

No branches or pull requests
1 participant
@mp911de