Skip to content

Cycle in projection -> convert (convert.Jsr310Converters) -> mapping -> projection #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Dec 14, 2021 · 3 comments
Closed

Cycle in projection -> convert (convert.Jsr310Converters) -> mapping -> projection #2514

mp911de opened this issue Dec 14, 2021 · 3 comments
Assignees
@schauder
Labels
type: task A general task

Comments

@mp911de
Copy link
Member

mp911de commented Dec 14, 2021

With the introduction of entity projections we introduced a package cycle. The project package uses Jsr310Converters which could be moved either out of the package or we could move EntityProjectionIntrospector into the projection package as it already has access to convert.

/cc @meistermeier
@mp911de mp911de added the type: task A general task label Dec 14, 2021
@schauder
Copy link
Contributor

Screenshot 2021-12-14 at 14 37 41

@schauder
Copy link
Contributor

Just moving Jsr310Converters wouldn't help, since it depends on ReadingConverter and WritingConverter.

Moving EntityProjectionIntrospector to projection together with EntityProjection sounds like the right thing to do.

@schauder schauder self-assigned this Dec 14, 2021
@mp911de
Copy link
Member Author

mp911de commented Dec 14, 2021

Makes sense since it's a new API. Requires subsequent changes in MongoDB (main) and Cassandra (once merged).

christophstrobl added a commit to spring-projects/spring-data-mongodb that referenced this issue Dec 14, 2021
@christophstrobl
Adapt to changes in data-commons.
8be5dd3 
See: spring-projects/spring-data-commons#2514
Related to: #3894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

Labels
type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schauder @mp911de