Skip to content

Revisit MethodsMetadataReader design #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Nov 18, 2021 · 2 comments
Closed

Revisit MethodsMetadataReader design #2498

mp911de opened this issue Nov 18, 2021 · 2 comments
Assignees
@mp911de
Labels
status: superseded An issue that has been superseded by another theme: 3.0 type: task A general task

Comments

@mp911de
Copy link
Member

mp911de commented Nov 18, 2021 •
edited
Loading

Spring Framework has removed its metadata-reading visitors and we need to revisit our model to decide how to design our metadata readers for MethodsMetadata.

See also #2499
@mp911de mp911de added type: task A general task theme: 3.0 labels Nov 18, 2021
@mp911de mp911de self-assigned this Nov 18, 2021
mp911de added a commit that referenced this issue Nov 18, 2021
@mp911de
Introduce local copies of removed Spring Framework API for ASM metada…
1d42b59 
…ta parsing.

Should be removed after revisiting our design.

See #2498
@mp911de
Copy link
Member Author

mp911de commented Nov 19, 2021

Depends on spring-projects/spring-framework#27701

@mp911de mp911de added the status: blocked An issue that's blocked on an external project change label Nov 19, 2021
christophstrobl added a commit that referenced this issue Nov 22, 2021
@christophstrobl
Remove invalid imports from types used for ASM metadata parsing.
2adca7e 
See #2498
mp911de added a commit that referenced this issue Jan 3, 2022
@mp911de
Introduce local copies of removed Spring Framework API for ASM metada…
9e9be81 
…ta parsing.

Should be removed after revisiting our design.

See #2498
mp911de pushed a commit that referenced this issue Jan 3, 2022
@christophstrobl @mp911de
Remove invalid imports from types used for ASM metadata parsing.
66047c3 
See #2498
@mp911de mp911de added status: superseded An issue that has been superseded by another and removed status: blocked An issue that's blocked on an external project change labels Jan 3, 2022
@mp911de
Copy link
Member Author

mp911de commented Jan 3, 2022

Superseded by #2520

@mp911de mp911de closed this as completed Jan 3, 2022
schauder pushed a commit that referenced this issue Jan 13, 2022
@mp911de @schauder
Introduce local copies of removed Spring Framework API for ASM metada…
227c50b 
…ta parsing.

Should be removed after revisiting our design.

See #2498
schauder pushed a commit that referenced this issue Jan 13, 2022
@christophstrobl @schauder
Remove invalid imports from types used for ASM metadata parsing.
2ee509b 
See #2498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

Labels
status: superseded An issue that has been superseded by another theme: 3.0 type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mp911de