Skip to content

PersistentPropertyPathFactory should use contextual property information. #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christophstrobl opened this issue Feb 4, 2021 · 0 comments
Closed

PersistentPropertyPathFactory should use contextual property information. #2293

christophstrobl opened this issue Feb 4, 2021 · 0 comments
Assignees
@christophstrobl
Labels
type: enhancement A general enhancement
Milestone
2.5 M3 (2021.0.0)

Comments

@christophstrobl
Copy link
Member

In oder to preserve contextual information the PersistentPropertyPathFactory should obtain EntityInformation for properties from the MappingContext via their PersistentProperty representation instead of plain TypeInformation as the former contains more information about the actual type and signatures.

Related to: spring-projects/spring-data-mongodb#2803
@christophstrobl christophstrobl self-assigned this Feb 4, 2021
@christophstrobl christophstrobl added the type: enhancement A general enhancement label Feb 4, 2021
This was referenced Feb 4, 2021
Closed
Closed
@mp911de mp911de added this to the 2.5 M3 (2021.0.0) milestone Feb 16, 2021
@christophstrobl christophstrobl mentioned this issue May 31, 2021
Closed
christophstrobl added a commit to spring-projects/spring-data-mongodb that referenced this issue Jun 1, 2021
@christophstrobl
Fix query mapper path resolution for types considered simple ones.
cf3e850 
spring-projects/spring-data-commons#2293 changed how PersistentProperty paths get resolved and considers potentially registered converters for those, which made the path resolution fail in during the query mapping process.
This commit makes sure to capture the according exception and continue with the given user input.

Fixes: #3659
@christophstrobl christophstrobl mentioned this issue Jun 1, 2021
Closed
mp911de pushed a commit to spring-projects/spring-data-mongodb that referenced this issue Jun 18, 2021
@christophstrobl @mp911de
Fix query mapper path resolution for types considered simple ones.
a1c1659 
spring-projects/spring-data-commons#2293 changed how PersistentProperty paths get resolved and considers potentially registered converters for those, which made the path resolution fail in during the query mapping process.
This commit makes sure to capture the according exception and continue with the given user input.

Fixes: #3659
Original pull request: #3661.
mp911de pushed a commit to spring-projects/spring-data-mongodb that referenced this issue Jun 18, 2021
@christophstrobl @mp911de
Fix query mapper path resolution for types considered simple ones.
0114150 
spring-projects/spring-data-commons#2293 changed how PersistentProperty paths get resolved and considers potentially registered converters for those, which made the path resolution fail in during the query mapping process.
This commit makes sure to capture the according exception and continue with the given user input.

Fixes: #3659
Original pull request: #3661.
mp911de pushed a commit to spring-projects/spring-data-mongodb that referenced this issue Jun 18, 2021
@christophstrobl @mp911de
Fix query mapper path resolution for types considered simple ones.
99eb849 
spring-projects/spring-data-commons#2293 changed how PersistentProperty paths get resolved and considers potentially registered converters for those, which made the path resolution fail in during the query mapping process.
This commit makes sure to capture the according exception and continue with the given user input.

Fixes: #3659
Original pull request: #3661.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.5 M3 (2021.0.0)
2 participants
@mp911de @christophstrobl