Add configuration to disable entity lifecycle events #1291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now support disabling lifecycle events through the Template API to reduce the framework overhead when events are not needed.
schauder
approved these changes
Jul 20, 2022
| @@ -190,11 +191,12 @@ public AsyncCassandraTemplate(AsyncCqlTemplate asyncCqlTemplate, CassandraConver | |||
| this.entityOperations = new EntityOperations(converter); | |||
| this.exceptionTranslator = asyncCqlTemplate.getExceptionTranslator(); | |||
| this.statementFactory = new StatementFactory(converter); | |||
| this.eventDelegate = new EntityLifecycleEventDelegate(); | |||
There was a problem hiding this comment.
Nitpicking: I'd prefer to initialize this on declaration since it does not depend on anything in the constructor.
...-cassandra/src/main/java/org/springframework/data/cassandra/core/AsyncCassandraTemplate.java
Show resolved
Hide resolved
| @@ -183,6 +184,7 @@ public CassandraTemplate(CqlOperations cqlOperations, CassandraConverter convert | |||
| this.cqlOperations = cqlOperations; | |||
| this.entityOperations = new EntityOperations(converter); | |||
| this.statementFactory = new StatementFactory(new QueryMapper(converter), new UpdateMapper(converter)); | |||
| this.eventDelegate = new EntityLifecycleEventDelegate(); | |||
There was a problem hiding this comment.
Again: I'd prefer initialization at declaration time when possible.
| @@ -190,6 +191,7 @@ public ReactiveCassandraTemplate(ReactiveCqlOperations reactiveCqlOperations, Ca | |||
| this.cqlOperations = reactiveCqlOperations; | |||
| this.entityOperations = new EntityOperations(converter); | |||
| this.statementFactory = new StatementFactory(converter); | |||
| this.eventDelegate = new EntityLifecycleEventDelegate(); | |||
| return getReactiveCqlOperations() | ||
| .execute(new GetConfiguredPageSize()) | ||
| .single(); | ||
| return getReactiveCqlOperations().execute(new GetConfiguredPageSize()).single(); |
There was a problem hiding this comment.
We should protect the previous formatting in this case.
| @@ -530,6 +533,8 @@ Being based on Spring's application context event infrastructure lets other prod | |||
|
|
|||
| To intercept an object before it goes into the database, you can register a subclass of `org.springframework.data.cassandra.core.mapping.event.AbstractCassandraEventListener` that overrides the `onBeforeSave(…)` method. | |||
| When the event is dispatched, your listener is called and passed the domain object (which is a Java entity). | |||
| Entity lifecycle events can be costly and you may notice a change in the performance profile when loading large result sets. | |||
| You can disable lifecycle events on the Template API object. | |||
There was a problem hiding this comment.
A link to the setEnabled methods in the API doc would be nice. At least we should name the method explicitly so the user doesn't have to search for the right method.
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1286