Skip to content

Support configurable batch types for batch operations. #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Support configurable batch types for batch operations. #1175

wants to merge 3 commits into from

Conversation

samueldlightfoot
Copy link
Contributor

@samueldlightfoot samueldlightfoot commented Sep 30, 2021 •
edited
Loading

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

I haven't added explicit test cases as the new constructor is called as part of the chain for the pre-existing constructor. Happy to add them if we think there's benefit.

@pivotal-cla
Copy link

@samueldlightfoot Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@samueldlightfoot Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 30, 2021
@mp911de mp911de self-assigned this Sep 30, 2021
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 30, 2021
@mp911de mp911de added this to the 3.2.6 (2021.0.6) milestone Sep 30, 2021
@mp911de mp911de linked an issue Sep 30, 2021 that may be closed by this pull request
Support configurable batch types for batch operations #1174
Closed
mp911de pushed a commit that referenced this pull request Oct 1, 2021
@samueldlightfoot @mp911de
Support configurable batch types for batch operations.
acc867a 
Closes #1174
Original pull request: #1175.
mp911de added a commit that referenced this pull request Oct 1, 2021
@mp911de
Polishing.
9d1c762 
Remove constructors defaulting to BatchType.LOGGED and turn batchOps() into default methods to avoid defaulting sprawl.

Update since tags.

See #1174
Original pull request: #1175.
mp911de pushed a commit that referenced this pull request Oct 1, 2021
@samueldlightfoot @mp911de
Support configurable batch types for batch operations.
99f3bcc 
Closes #1174
Original pull request: #1175.
mp911de added a commit that referenced this pull request Oct 1, 2021
@mp911de
Polishing.
5718ec3 
Remove constructors defaulting to BatchType.LOGGED and turn batchOps() into default methods to avoid defaulting sprawl.

Update since tags.

See #1174
Original pull request: #1175.
@mp911de
Copy link
Member

mp911de commented Oct 1, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Oct 1, 2021
@samueldlightfoot samueldlightfoot deleted the 1174-configurable-batch-types branch October 6, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.2.6 (2021.0.6)
Development

Successfully merging this pull request may close these issues.

Support configurable batch types for batch operations
4 participants
@samueldlightfoot @pivotal-cla @mp911de @spring-projects-issues