Skip to content

Alter the new-issue-branch script to handle both calver AND the legacy format. #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Alter the new-issue-branch script to handle both calver AND the legacy format. #1102

wants to merge 2 commits into from

Conversation

gregturn
Copy link
Contributor

No description provided.

@gregturn gregturn requested a review from mp911de May 19, 2020 15:47
@gregturn
Copy link
Contributor Author

gregturn commented May 19, 2020 •
edited
Loading

@mp911de I have adjusted our script to handle both versions. And you see it in action.

  • Legacy versions will now look like "1.1.0.BUILD-SNAPSHOT" -> "1.1.0.BUILD-MY-ISSUE-SNAPSHOT",
  • The branches will still be seen by Jenkins as "issue/MY-ISSUE" branches.
  • They will get deployed to Artifactory provided Jenkinsfile only looks for endsWith("SNAPSHOT") in their respective project.

@mp911de mp911de changed the title Alter the new-issue-branch script to handle both calvar AND the legacy format. Alter the new-issue-branch script to handle both calver AND the legacy format. May 20, 2020
mp911de pushed a commit that referenced this pull request May 20, 2020
@gregturn @mp911de
#1101 - Adapt new-issue-branch to handle calver and old versioning.
d0f86fe 
Original pull request: #1102.
@mp911de
Copy link
Member

mp911de commented May 20, 2020

Thanks a lot, that's merged now.

@mp911de mp911de closed this May 20, 2020
@mp911de mp911de deleted the issue/SDBUILD-1101 branch September 20, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregturn @mp911de