With Tomcat, enable HTTP/2 by default #9964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds AprLifecycleListener to the Tomcat listeners. Fixes spring-projects#7376
Note that, until Java 9 arrives with ALPN support (JEP-244), tomcat-native/APR must be available in order for Tomcat to enable HTTP/2 (if it is not available, an error is logged but everything otherwise still works).
spring-projects-issues
added
the
status: waiting-for-triage
|
The tomcat-native / libtcnative-1 package isn't available on Travis CI right now so we can't add this package to .travis.yml to facilitate testing of this functionality. I've requested it be added at travis-ci/apt-package-safelist#4215 |
|
Thanks for the PR. Generally speaking, when all three containers have the same functionality, we like to support it consistently across all three. In other words, it's unlikely that we'll merge this while it's Tomcat-specific. A different approach, that covers all three containers but doesn't enabled HTTP/2 by default, is being proposed in #9981. |
wilkinsona
added
priority: normal
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using embedded Tomcat, enable HTTP/2 for connectors by default.
Tomcat's HTTP/2 support depends on tomcat-native/APR; if that's not available, Tomcat simply logs a message and continues on without HTTP/2 support (in other words, nothing is broken).
Since this change enables APR (if it's available), it also improves performance in general (if APR is available) by using the OpenSSL engine instead of JSSE, fixing #7376