Skip to content

Polishing BatchAutoConfigurationTests #44800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Mar 20, 2025

  1. Rename TestConfiguration to TestJpaConfiguration and remove unnecessary reference.
  2. Use withBean instead of withUserConfiguration to avoid new configuration class.
  3. Use kebab-case for configuration key.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 20, 2025
@wilkinsona wilkinsona added this to the 3.3.x milestone Mar 20, 2025
@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 20, 2025
1. Rename `TestConfiguration` to `TestJpaConfiguration` and remove unnecessary reference.
2. Use `withBean` instead of `withUserConfiguration` to avoid new configuration class.
3. Use kebab-case for configuration key

Signed-off-by: Yanming Zhou <[email protected]>
@snicoll snicoll self-assigned this Mar 21, 2025
@snicoll snicoll modified the milestones: 3.3.x, 3.3.11 Mar 21, 2025
snicoll pushed a commit that referenced this pull request Mar 21, 2025
1. Rename `TestConfiguration` to `TestJpaConfiguration` and remove unnecessary reference.
2. Use `withBean` instead of `withUserConfiguration` to avoid new configuration class.
3. Use kebab-case for configuration key

See gh-44800

Signed-off-by: Yanming Zhou <[email protected]>
snicoll added a commit that referenced this pull request Mar 21, 2025
@snicoll snicoll closed this in 67f9cc5 Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants