Prevent redis pool to initialize in unit test #43774
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects/spring-data-redis@b7381ac introduces an unconditionally preparePool invocation when starting JedisConnectionFactory/LettuceConnectionFactory, causing it attempts to create a socket to the dummy domain name `foo`. Signed-off-by: He Zean <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
snicoll
added
type: task
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Jan 11, 2025
See gh-43774 Signed-off-by: He Zean <[email protected]>
snicoll
added a commit
that referenced
this pull request
Jan 11, 2025
|
@hezean thanks very much. |
philwebb
added a commit
that referenced
this pull request
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As 52d419a bumps spring-data bom to
2024.1.2-SNAPSHOT, an unconditional preparePool invocation is added to the start lifecycle of JedisConnectionFactory (see: spring-projects/spring-data-redis@2bcdd36). That is, withmin-idleset to 1, the pool will attempt to create a socket over the dummy domainfoo, failing the bean creation.Related to: