Skip to content

feat: Optimize DatabaseDriver fromJdbcUrl method with caching #43637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+16 −2
Closed

feat: Optimize DatabaseDriver fromJdbcUrl method with caching #43637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions ...-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/DatabaseDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Locale;
import java.util.Map;
import java.util.Set;

import org.springframework.util.Assert;
import org.springframework.util.StringUtils;
Expand Down Expand Up @@ -228,6 +232,14 @@ protected Collection<String> getUrlPrefixes() {

private final String validationQuery;

private static final Map<DatabaseDriver, Set<String>> URL_PREFIX_CACHE = new HashMap<>();

static {
for (DatabaseDriver driver : values()) {
URL_PREFIX_CACHE.put(driver, new HashSet<>(driver.getUrlPrefixes()));
}
}

DatabaseDriver(String productName, String driverClassName) {
this(productName, driverClassName, null);
}
Expand Down Expand Up @@ -296,8 +308,9 @@ public static DatabaseDriver fromJdbcUrl(String url) {
if (StringUtils.hasLength(url)) {
Assert.isTrue(url.startsWith("jdbc"), "URL must start with 'jdbc'");
String urlWithoutPrefix = url.substring("jdbc".length()).toLowerCase(Locale.ENGLISH);
for (DatabaseDriver driver : values()) {
for (String urlPrefix : driver.getUrlPrefixes()) {
for (Map.Entry<DatabaseDriver, Set<String>> entry : URL_PREFIX_CACHE.entrySet()) {
DatabaseDriver driver = entry.getKey();
for (String urlPrefix : entry.getValue()) {
String prefix = ":" + urlPrefix + ":";
if (driver != UNKNOWN && urlWithoutPrefix.startsWith(prefix)) {
return driver;
Expand All @@ -308,6 +321,7 @@ public static DatabaseDriver fromJdbcUrl(String url) {
return UNKNOWN;
}


/**
* Find a {@link DatabaseDriver} for the given product name.
* @param productName product name
Expand Down
Loading