Skip to content

Use activemq-client dependency vs transitional activemq-client-jakarta #40028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use activemq-client dependency vs transitional activemq-client-jakarta #40028

wants to merge 1 commit into from

Conversation

mattrpav
Copy link
Contributor

@mattrpav mattrpav commented Mar 19, 2024 •
edited
Loading

Use the activemq-client dependency per: #40027

Ahead of adding embedded broker support in as part of [#38404]

@mattrpav
Copy link
Contributor Author

@wilkinsona for your review. This would be cleaner to have in ahead of [#38404].

NOTE: I'll be removing activemq-client-jakarta module in next ActiveMQ 6.x release. (The Maven relocation has been published.)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 19, 2024
wilkinsona
wilkinsona requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, @mattrpav. It looks good to me other than I think we should leave spring-boot-dependencies as-is so that we continue to manage activemq-client-jakarta for now.

BTW, have you considered publishing a bom for ActiveMQ? We would certainly welcome it as it would save us from having to manually list ~all of ActiveMQ Classic's modules.

@wilkinsona wilkinsona mentioned this pull request Mar 19, 2024
Closed
@mattrpav
Copy link
Contributor Author

@wilkinsona re: activemq-bom yep ;-) I've already got a PR for it (apache/activemq#1178) that should land in the next ActiveMQ release.

@mattrpav mattrpav requested a review from wilkinsona March 19, 2024 18:14
@wilkinsona wilkinsona added the type: task A general task label Mar 19, 2024
@wilkinsona wilkinsona added this to the 3.3.x milestone Mar 19, 2024
@wilkinsona wilkinsona removed the status: waiting-for-triage An issue we've not yet triaged label Mar 19, 2024
@wilkinsona wilkinsona modified the milestones: 3.3.x, 3.3.0-M3 Mar 20, 2024
wilkinsona pushed a commit that referenced this pull request Mar 20, 2024
@mattrpav @wilkinsona
Use activemq-client instead of transitional activemq-client-jakarta
af18a69 
See gh-40028
@wilkinsona
Copy link
Member

Thanks very much, @mattrpav.

@adityaanand13
Copy link

thanks for the fix. I was about to raise the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona wilkinsona approved these changes

Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
3.3.0-M3
Development

Successfully merging this pull request may close these issues.
4 participants
@mattrpav @wilkinsona @adityaanand13 @spring-projects-issues