Upgrade to Groovy 3.0.7 #24946
Closed
Upgrade to Groovy 3.0.7 #24946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreis2211
commented
Jan 20, 2021
| @@ -87,7 +87,8 @@ void setUpExpectations() { | |||
|
|
|||
| @Test | |||
| void transformationOfAnnotationOnImport() { | |||
| this.moduleNode.addImport(null, null, Arrays.asList(this.grabAnnotation)); | |||
| ClassNode classNode = new ClassNode("Test", 0, new ClassNode(Object.class)); | |||
There was a problem hiding this comment.
Passing null throws an NPE these days.
|
Apparently, I need to check why my local builds didn't report the same build failure as on Concourse. I will work on the build error of course. |
szpak
reviewed
Jan 20, 2021
| @@ -17,7 +16,7 @@ class Example implements CommandLineRunner { | |||
|
|
|||
| void run(String... args) { | |||
| def port = context.webServer.port | |||
| def world = new RESTClient("http://localhost:" + port).get(path:"/").data.text | |||
| def world = new RestTemplate().getForObject("http://localhost:" + port + "/", String.class); | |||
There was a problem hiding this comment.
Suggested change
| def world = new RestTemplate().getForObject("http://localhost:" + port + "/", String.class); | |
| def world = new RestTemplate().getForObject("http://localhost:$port/", String.class); |
It's more the Groovy way :).
There was a problem hiding this comment.
Anyway, I would put here int and String instead of just def for clarity.
There was a problem hiding this comment.
Thanks for taking a look, @szpak. Those are good changes to make, but they're unrelated to an upgrade to Groovy 3.0 so let's keep them separate from this PR please.
szpak
approved these changes
Jan 20, 2021
|
Thank you very much, @dreis2211. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR tackles #20119 as discussed.
Let me know what you think.
Cheers,
Christoph