Skip to content

Document that JUnit 4 is the default #16707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Document that JUnit 4 is the default #16707

wants to merge 2 commits into from

Conversation

Tetsuya3850
Copy link
Contributor

I assumed the latest spring boot starter test uses JUnit 5 and had to scratch my head over it. I suggest adding it to the documentation as other people may be confused as well.

Reference
http://central.maven.org/maven2/org/springframework/boot/spring-boot-starter-test/2.1.4.RELEASE/spring-boot-starter-test-2.1.4.RELEASE.pom

I assumed the latest spring boot starter test uses JUnit 5 and had to scratch my head over it. I suggest adding it to the documentation as other people may be confused as well.

Reference
http://central.maven.org/maven2/org/springframework/boot/spring-boot-starter-test/2.1.4.RELEASE/spring-boot-starter-test-2.1.4.RELEASE.pom
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 2, 2019
@Tetsuya3850
Copy link
Contributor Author

Tetsuya3850 commented May 3, 2019

Add Note

This part seemed to imply that the latest is JUnit 5.

If you are using JUnit 4, don’t forget to also add @RunWith(SpringRunner.class) to your test, otherwise the annotations will be ignored. If you are using JUnit 5, there’s no need to add the equivalent @ExtendWith(SpringExtension.class) as @SpringBootTest and the other @…Test annotations are already annotated with it.

@wilkinsona
Copy link
Member

Thanks for the suggestion. We already mention that JUnit 4 is the default in the Kotlin testing section. I can't see any harm in mentioning it more generally, but I think it would be better done in this section. If you agree, would you like to update your proposal?

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label May 3, 2019
@Tetsuya3850
Copy link
Contributor Author

Ah,,, I have missed it since I do not use Kotlin. Yes, I will update my proposal based on your suggestion!

I have deleted the initial doc proposal and moved the information to the place where suggested.
@Tetsuya3850
Copy link
Contributor Author

I moved the doc to a more appropriate place!

@snicoll snicoll changed the title Doc that the latest spring-boot-test includes JUnit 4 Document that JUnit 4 is the default May 3, 2019
@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels May 3, 2019
@snicoll snicoll self-assigned this May 3, 2019
@snicoll snicoll added this to the 2.1.5 milestone May 3, 2019
snicoll pushed a commit that referenced this pull request May 3, 2019
snicoll added a commit that referenced this pull request May 3, 2019
* pr/16707:
  Polish "Document that JUnit 4 is the default"
  Document that JUnit 4 is the default
@snicoll snicoll closed this in 51c0fdc May 3, 2019
@snicoll
Copy link
Member

snicoll commented May 3, 2019

@Tetsuya3850 thank you, this is now merged in 2.1.x and master.

@Tetsuya3850 Tetsuya3850 deleted the update-readme branch May 3, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants