Add check for missing Liquibase's class CustomResolverServiceLocator
#11625
Conversation
`CustomResolverServiceLocator` was introduced in Liquibase 2.0.4, this check prevents failures during initialization when previous versions are used. See spring-projectsgh-11608
spring-projects-issues
added
the
status: waiting-for-triage
There was a problem hiding this comment.
Thanks for the PR @eddumelendez - Can you please add a test for the scenario?
| CommonsLoggingLiquibaseLogger.class.getPackage().getName()); | ||
| ServiceLocator.setInstance(customResolverServiceLocator); | ||
| liquibase.logging.LogFactory.reset(); | ||
| if (ClassUtils.isPresent("liquibase.servicelocator.CustomResolverServiceLocator", null)) { |
There was a problem hiding this comment.
Can we please have a test that exercises this behaviour. You can use the FilteredClassLoader for that.
There was a problem hiding this comment.
I think the new check is in the wrong place. I’d expect it to replace the existing check above.
There was a problem hiding this comment.
Also, given that we use Liquibase 3.5.x in 1.5, it would be worth looking to see if there’s a class that’s new in 3.5 that we can check for. We should review the auto-configuration conditions too.
snicoll
added
the
status: waiting-for-feedback
|
@eddumelendez I've applied those suggestions to 08ec3d2. Thanks for the PR |
snicoll
added
status: declined
|
sorry, I couldn't apply changes on time :( Thanks @snicoll for the hint to test this scenario |
CustomResolverServiceLocatorwas introduced in Liquibase 2.0.4, thischeck prevents failures during initialization when previous versions are
used.
See gh-11608