Remove JsonFormat from AuditEvent #11588
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to align the timestamp format of auditevents to the traces remove the @jsonformat annotation. This way the date is serialized using the object mapper's default configuration (as for the traces). With the spring boot 2.0 default this results in milliseconds to be serialized in the json. This allow finer grained querying for events via http as it may be useful for subsequent requests fetching all new events after the last knwon timestamp from the previous request.
spring-projects-issues
added
the
status: waiting-for-triage
|
Relates to #10976 |
|
Thanks for the PR, @joshiste. IMO, there isn't much point in making this change in isolation. What's being proposed here is a small piece of what #10976 will do. I'd rather do it all in one place as it'll make the change history cleaner. I'll make a note in #10976 so that the removal of any JSON formatting annotations isn't forgotten. |
wilkinsona
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to align the timestamp format of auditevents with the traces
remove the
@JsonFormatannotation. This way the date is serialized usingthe object mapper's default configuration (as for the traces).
With the spring boot 2.0 default this results in milliseconds to be
serialized in the json. This allow finer grained querying for events via
http as it may be useful for subsequent requests fetching all new events
after the last knwon timestamp from the previous request.