Skip to content

Upgrade to Maven Surefire/Failsafe Plugin 2.20.1+ #9414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Jun 6, 2017 · 5 comments
Closed

Upgrade to Maven Surefire/Failsafe Plugin 2.20.1+ #9414

philwebb opened this issue Jun 6, 2017 · 5 comments
Assignees
@wilkinsona
Labels
type: enhancement A general enhancement
Milestone
2.0.0.M5

Comments

@philwebb
Copy link
Member

philwebb commented Jun 6, 2017

See #6299 for our first attempt. It looks like a memory leak that we may need to report to the surefire team.
@philwebb philwebb added this to the 2.0.0.M3 milestone Jun 6, 2017
@marcphilipp marcphilipp mentioned this issue Jun 10, 2017
Closed
@shakuzen
Copy link
Member

I'm not sure if the cause is the same, but SUREFIRE-1382 was found and recently fixed in surefire. It should be in the upcoming version 2.20.1 (and in 2.21-SNAPSHOT already).

@wilkinsona
Copy link
Member

Thanks, @shakuzen. That does sound pretty similar.

@wilkinsona wilkinsona mentioned this issue Jun 27, 2017
Closed
@SebastianDietrich
Copy link

please upgrade as well maven-failsafe-plugin (has traditionally the same version as surefire)

@philwebb philwebb changed the title Upgrade to Maven Surefire Plugin 2.20+ Upgrade to Maven Surefire/Failsafe Plugin 2.20+ Jun 28, 2017
@wilkinsona wilkinsona changed the title Upgrade to Maven Surefire/Failsafe Plugin 2.20+ Upgrade to Maven Surefire/Failsafe Plugin 2.20.1+ Jun 29, 2017
@wilkinsona wilkinsona added the status: blocked An issue that's blocked on an external project change label Jul 21, 2017
@wilkinsona
Copy link
Member

There's no release date set for 2.20.1 and there are still 3 open issues. Moving to M4.

@wilkinsona wilkinsona modified the milestones: 2.0.0.M4, 2.0.0.M3 Jul 26, 2017
@snicoll snicoll modified the milestones: 2.0.0.M4, 2.0.0.M5 Aug 23, 2017
@wilkinsona wilkinsona self-assigned this Sep 19, 2017
@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Sep 19, 2017
@wilkinsona
Copy link
Member

Good news: 2.20.1 is out. Bad news: JUnit 5 isn't compatible with it. See this issue for details. We'll need to update our Junit 5 sample to downgrade Surefire to 2.19.1 as part of this.

mmedenjak pushed a commit to mmedenjak/hazelcast that referenced this issue Oct 2, 2017
Revert "Removes patched surefire dependency"
0924225 
This reverts commit b8498d4 because of issues with HealthMonitor.stop
taking a long time. Also, a memory leak has been identified with the
latest surefire version:
junit-team/junit5#809
spring-projects/spring-boot#9414
@mmedenjak mmedenjak mentioned this issue Oct 2, 2017
Merged
@snicoll snicoll mentioned this issue Feb 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.0.0.M5
Development

No branches or pull requests
5 participants
@snicoll @philwebb @SebastianDietrich @wilkinsona @shakuzen