Skip to content

ImportCandidates does not use the same default class loader as SpringFactoriesLoader #44448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Feb 26, 2025 · 1 comment
Closed

ImportCandidates does not use the same default class loader as SpringFactoriesLoader #44448

wilkinsona opened this issue Feb 26, 2025 · 1 comment
Labels
status: invalid An issue that we don't feel is valid type: bug A general bug

Comments

@wilkinsona
Copy link
Member

Forward port of issue #44401 to 3.4.x.
@wilkinsona wilkinsona added status: forward-port An issue tracking the forward-port of a change made in an earlier branch type: bug A general bug labels Feb 26, 2025
@wilkinsona wilkinsona added this to the 3.4.4 milestone Feb 26, 2025
@wilkinsona wilkinsona mentioned this issue Feb 26, 2025
Closed
wilkinsona added a commit that referenced this issue Feb 27, 2025
@wilkinsona
Merge branch '3.3.x' into 3.4.x
cbf9cb0 
See gh-44448
@wilkinsona
Copy link
Member Author

I was mistaken. While the ClassLoader is @Nullable and when it is null SpringFactoriesLoader will use ClassUtils.getDefaultClassLoader(), all of the static methods that can create an instance will never pass in null. Instead, they use SpringFactoriesLoader.class.getClassLoader() as the default. This change has been reverted in cbf9cb0.

@wilkinsona wilkinsona added status: invalid An issue that we don't feel is valid and removed status: forward-port An issue tracking the forward-port of a change made in an earlier branch labels Feb 27, 2025
@wilkinsona wilkinsona removed this from the 3.4.4 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: invalid An issue that we don't feel is valid type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wilkinsona