Skip to content

Upgrade to Jetty 12.0.12 #41770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Aug 10, 2024 · 2 comments
Closed

Upgrade to Jetty 12.0.12 #41770

snicoll opened this issue Aug 10, 2024 · 2 comments
Assignees
@snicoll
Labels
type: dependency-upgrade A dependency upgrade
Milestone
3.2.9

Comments

@snicoll
Copy link
Member

snicoll commented Aug 10, 2024

No description provided.

@snicoll snicoll added the type: dependency-upgrade A dependency upgrade label Aug 10, 2024
@snicoll snicoll added this to the 3.2.9 milestone Aug 10, 2024
@snicoll
Copy link
Member Author

snicoll commented Aug 10, 2024 •
edited
Loading

Jetty has deprecated WebInfConfiguration.getCanonicalNameForWebAppTmpDir that we use to source the temporary directory the embedded Jetty server uses. I am not sure what to do with the deprecation.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Aug 10, 2024
@wilkinsona
Copy link
Member

I think we can switch to the new getCanonicalNameForTmpDir method that was added to WebAppContext in 12.0.12. That would make us incompatible with Jetty 12.0.11 and earlier. If we want to maintain some backwards compatibility, we could fall back to WebInfConfiguration.getCanonicalNameForWebAppTmpDir if a call to getCanonicalNameForTmpDir results in a NoSuchMethodError.

@snicoll snicoll removed the for: team-attention An issue we'd like other members of the team to review label Aug 12, 2024
@snicoll snicoll self-assigned this Aug 12, 2024
snicoll added a commit to snicoll/spring-boot that referenced this issue Aug 12, 2024
@snicoll
Upgrade to Jetty 12.0.12
7d71c39 
Closes spring-projectsgh-41770
@snicoll snicoll mentioned this issue Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
3.2.9
Development

No branches or pull requests
2 participants
@snicoll @wilkinsona