Skip to content

Add CI for Java 23 #41698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Aug 5, 2024 · 3 comments
Closed

Add CI for Java 23 #41698

snicoll opened this issue Aug 5, 2024 · 3 comments
Assignees
@snicoll
Labels
type: task A general task
Milestone
3.2.9

Comments

@snicoll
Copy link
Member

snicoll commented Aug 5, 2024

With Java 23 in its RC phase this week and GA in September, we should add CI for it. Framework supports Java 23 in 6.1+, limiting our Java 23 support to Boot 3.2+.
@snicoll snicoll added the type: task A general task label Aug 5, 2024
@snicoll snicoll added this to the 3.2.x milestone Aug 5, 2024
@snicoll
Copy link
Member Author

snicoll commented Aug 6, 2024 •
edited
Loading

So if we want to test, we need to downgrade to Awaitility 4.2.0 again. There is a PR but the project owners haven't reviewed it in months unfortunately.

I've downgraded locally and we're getting more Java Security Manager problem:

Courtesy of @mhalbritter, this seems to be due to https://bugs.openjdk.org/browse/JDK-8327134.

We could either disable those tests or use the -Djava.security.manager=allow workaround.

This 3.2.x branch has a number of exclude and is green with Java 23: https://github.com/snicoll/spring-boot/tree/gh-41698

@snicoll
Copy link
Member Author

snicoll commented Aug 6, 2024 •
edited
Loading

3.3.x is breaking pretty much any use of Mockito on Java 23 due to couchbase-client shipping an old version of Bytebuddy. We'd need to make an exception to our upgrade policy and upgrade to 3.7.1. I've reported the issue so that we could maybe get a backport of the fix in the version 3.3.x uses.

@snicoll snicoll added the for: team-meeting An issue we'd like to discuss as a team to make progress label Aug 7, 2024
@snicoll
Copy link
Member Author

snicoll commented Aug 7, 2024

Awaitility 4.2.2 has been released with a fix 🥳

@snicoll snicoll mentioned this issue Aug 7, 2024
Closed
@snicoll snicoll self-assigned this Aug 7, 2024
@snicoll snicoll removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Aug 7, 2024
@snicoll snicoll mentioned this issue Aug 7, 2024
Closed
snicoll added a commit that referenced this issue Aug 7, 2024
@snicoll
Enable Java 23-ea on CI
7273a4b 
See gh-41698
@snicoll snicoll closed this as completed in 9e602ac Aug 7, 2024
snicoll added a commit that referenced this issue Aug 7, 2024
@snicoll
Don't pass -ea suffix into Gradle as the toolchain version
d382f2e 
This commit is similar to what we had to do for Java 22-ea.

Given our actions have changed quite a bit, this commit replaces the
"java-distribution" parameter by a "java-early-access" parameter. When
set, it automatically switches the distribution to temurin as well as
applying the same handling of the Java version as in b8a6cab.

See gh-41698
snicoll added a commit that referenced this issue Aug 7, 2024
@snicoll
Don't pass -ea suffix into Gradle as the toolchain version
00cfe4d 
This commit is similar to what we had to do for Java 22-ea.

Given our actions have changed quite a bit, this commit replaces the
"java-distribution" parameter by a "java-early-access" parameter. When
set, it automatically switches the distribution to temurin as well as
applying the same handling of the Java version as in b8a6cab.

See gh-41698
@snicoll snicoll modified the milestones: 3.2.x, 3.2.9 Aug 8, 2024
snicoll added a commit that referenced this issue Aug 13, 2024
@snicoll
Adapt LoaderIntegrationTests to Java 23
68ce174 
See gh-41698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
3.2.9
Development

No branches or pull requests
1 participant
@snicoll