Skip to content

Deprecate LOGGED_APPLICATION_NAME log property in favor of APPLICATION_NAME with the verbatim value #41444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Jul 11, 2024 · 1 comment
Closed

Deprecate LOGGED_APPLICATION_NAME log property in favor of APPLICATION_NAME with the verbatim value #41444

philwebb opened this issue Jul 11, 2024 · 1 comment
Assignees
@philwebb
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Milestone
3.4.0-M1

Comments

@philwebb
Copy link
Member

In order to support #5479 we need to access application.name. Currently we only store the value as LOGGED_APPLICATION_NAME and it is formatted inside square brackets with a trailing space. We should be able to replace the stored formatting with a customer converter, then store application.name directly so it can be used by structured logging.
@philwebb
Copy link
Member Author

As an added bonus, we can then also change APPLICATION_GROUP and remove the ApplicationGroupFormatter.

@philwebb philwebb added this to the 3.4.0-M1 milestone Jul 11, 2024
@philwebb philwebb self-assigned this Jul 11, 2024
@philwebb philwebb added type: enhancement A general enhancement status: noteworthy A noteworthy issue to call out in the release notes labels Jul 11, 2024
@wilkinsona wilkinsona changed the title Deprected LOGGED_APPLICATION_NAME log property in favor of APPLICATION_NAME with the verbatim value Deprecate LOGGED_APPLICATION_NAME log property in favor of APPLICATION_NAME with the verbatim value Jul 11, 2024
@izeye izeye mentioned this issue Sep 18, 2024
Closed
snicoll pushed a commit that referenced this issue Sep 19, 2024
@izeye @snicoll
Polish gh-39957 and gh-41444
94e8c5d 
See gh-42359
snicoll added a commit that referenced this issue Sep 19, 2024
@snicoll
Merge pull request #42359 from izeye
543bb80 
* pr/42359:
  Polish gh-39957 and gh-41444

Closes gh-42359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Projects
None yet
Milestone
3.4.0-M1
Development

No branches or pull requests
1 participant
@philwebb