-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Add resource hints for serving static web content #31278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is also |
Getting the actual value configured by the user is an interesting use case. We could watch for a There is also the Flagging for team attention to get feedback from the team. |
We've had some trouble in the past trying to make properties classes too clever so I think I'd prefer that they don't implement an additional interface. Resource hints are interesting and I'm a little worried that we can try and make things too clever and paint ourselves into a corner. For example, if we manage to support profiles with AOT then it's possible that the resource properties could change depending on the active profile. Since we won't know that at build time it will be hard for us to deduce the correct resources to include. Perhaps we'd be better off with an explicit configuration on the build plugin and align the default so it works for most applications. |
I went ahead and registered the defaults if they are available on the classpath. We could revisit this later if needed. I agree that trying to be too smart upfront is a bad idea. |
While working on spring-projects/spring-framework#28518, I found that I had to configure manually resource hints for resources located in
static/*
to be included in the native image in order to get those working on native images. Same need onpublic/*
and other directories (default ones, but also ideally customized ones if that's possible).Could you please add such resource hints for serving static web content?
The text was updated successfully, but these errors were encountered: