Skip to content

Upgrade to Micrometer 2.0.0-M3 #29753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Feb 11, 2022 · 3 comments
Closed

Upgrade to Micrometer 2.0.0-M3 #29753

wilkinsona opened this issue Feb 11, 2022 · 3 comments
Assignees
Labels
type: dependency-upgrade A dependency upgrade
Milestone

Comments

@wilkinsona
Copy link
Member

No description provided.

@wilkinsona wilkinsona added the type: dependency-upgrade A dependency upgrade label Feb 11, 2022
@wilkinsona wilkinsona added this to the 3.0.0-M2 milestone Feb 11, 2022
@wilkinsona wilkinsona self-assigned this Feb 11, 2022
@wilkinsona
Copy link
Member Author

wilkinsona commented Feb 11, 2022

This is blocked due to the breaking API changes affecting other projects. The following modules are affected:

  • HikariCP
  • lettuce-core
  • spring-batch-core
  • spring-kafka
  • stream-client (RabbitMQ)

spring-batch-core is the most problematic as Micrometer is integrated into AbstractJob. This means that we can only avoid the problem by removing Batch support entirely. For the others, we would only lose metrics integration.

@wilkinsona wilkinsona added the status: blocked An issue that's blocked on an external project change label Feb 11, 2022
@mhalbritter
Copy link
Contributor

mhalbritter commented Mar 1, 2022

See #30014 for the ticket which handles the micrometer-binders module. As soon as a micrometer 2.0.0 with the binders module is published, we should refactor the imports.

It's as easy as replace every import io.micrometer.core.instrument.binder. with import io.micrometer.binder. for every import except MeterBinder.

The auto-configurations only need to support the new binders, as Spring Boot 3.0 drops support for the old binders, therefore we don't need to do all the auto-configuration changes we did for 2.7 in #30014

@mhalbritter mhalbritter assigned mhalbritter and unassigned wilkinsona Mar 4, 2022
@mhalbritter mhalbritter changed the title Upgrade to Micrometer 2.0.0-M2 Upgrade to Micrometer 2.0.0-M3 Mar 4, 2022
@mhalbritter
Copy link
Contributor

main branch now builds against Micrometer 2.0.0-SNAPSHOT, which will be released as Micrometer 2.0.0-M3 on 2022-03-14.

@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

2 participants