Skip to content

Add Java 15 CI #21604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue May 28, 2020 · 11 comments
Closed

Add Java 15 CI #21604

wilkinsona opened this issue May 28, 2020 · 11 comments
Assignees
@dreis2211
Labels
status: superseded An issue that has been superseded by another type: task A general task

Comments

@wilkinsona
Copy link
Member

It might be a bit early for us (we waited for the JDK's RC phase for Java 14), but Framework 5.3 is building against Java 15 already. We should consider when we want to start doing the same.
@wilkinsona wilkinsona added the type: task A general task label May 28, 2020
@wilkinsona wilkinsona added this to the 2.4.x milestone May 28, 2020
@dreis2211
Copy link
Contributor

There are simply no AdoptOpenJDK builds for JDK 15 yet. I wonder if Spring Framework uses OpenJDK EA builds!?

@aahlenst
Copy link
Contributor

We're doing JDK 15 for quite some time: https://github.com/AdoptOpenJDK/openjdk15-binaries/releases. But we don't surface them yet on the website.

@dreis2211
Copy link
Contributor

dreis2211 commented May 28, 2020 •
edited
Loading

That's what I meant to say, sorry @aahlenst . Spring-Boot does a check against the API to check for JDK upgrades, which wouldn't work on 15 because it's not officially exposed to the outside. But that might be acceptable.

@dreis2211 dreis2211 mentioned this issue May 28, 2020
Closed
@dreis2211
Copy link
Contributor

Btw...I would volunteer to do this again for JDK 15.

@aahlenst
Copy link
Contributor

@dreis2211 If we can make anything easier, please open tickets in either https://github.com/AdoptOpenJDK/openjdk-website or https://github.com/AdoptOpenJDK/openjdk-api-v3.

@dreis2211
Copy link
Contributor

dreis2211 commented May 28, 2020 •
edited
Loading

@aahlenst I think there is already AdoptOpenJDK/openjdk-api-v3#212 that at least is going in the same direction of a missing entry for JDK 15 ;)

@philwebb
Copy link
Member

Btw...I would volunteer to do this again for JDK 15.

That would be great if you have time. Thanks @dreis2211!

@dreis2211
Copy link
Contributor

If there is no big pressure here, I'd like to resolve it in a way so that we don't have to skip the update logic for JDK 15, which means a little bit of waiting time until the AdoptOpenJDK issue is resolved. But I can also simply skip the update logic for JDK 15. Just let me know.

@snicoll
Copy link
Member

snicoll commented May 29, 2020

I don't think getting automatic update right away is a blocker. If that changes the pipeline config too much, we can wait.

@dreis2211
Copy link
Contributor

It doesn't - from what I have in mind. Just wanted to have it clarified upfront. Will work on JDK 15 next week then ;)

dreis2211 added a commit to dreis2211/spring-boot that referenced this issue Jun 5, 2020
@dreis2211
Add Java 15 CI
2af8f78 
Closes spring-projectsgh-21604
@dreis2211 dreis2211 mentioned this issue Jun 5, 2020
Closed
@snicoll
Copy link
Member

snicoll commented Jun 5, 2020

Closing in favour of PR #21173

@snicoll snicoll closed this as completed Jun 5, 2020
@snicoll snicoll removed this from the 2.4.x milestone Jun 5, 2020
@snicoll snicoll added the status: superseded An issue that has been superseded by another label Jun 5, 2020
dreis2211 added a commit to dreis2211/spring-boot that referenced this issue Jun 5, 2020
@dreis2211
Use Class.getName() in HandlerFunctionDescription
69b197b 
In JDK 15 the concept of hidden classes was introduced, which also affects
Lambdas in so far that Class.getCanonicalName() will return null for those.
Using Class.getName() works around that behavior change.

See spring-projectsgh-21604
dreis2211 added a commit to dreis2211/spring-boot that referenced this issue Jun 5, 2020
@dreis2211
Allow StringSequence.isEmpty() to be compatible with JDK 15
d21e15f 
JDK 15 introduces isEmpty() on CharSequence which clashes with the one declared
in StringSequence because it is not public.

See spring-projectsgh-21604
dreis2211 added a commit to dreis2211/spring-boot that referenced this issue Jun 11, 2020
@dreis2211
Only fallback to Class.getName() in HandlerFunctionDescription
603a1b8 
See spring-projectsgh-21604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreis2211 dreis2211

Labels
status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@aahlenst @snicoll @philwebb @wilkinsona @dreis2211