Skip to content

Configure PathPatternRouteMatcher at the RSocketStrategies level #17571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bclozel opened this issue Jul 18, 2019 · 0 comments
Closed

Configure PathPatternRouteMatcher at the RSocketStrategies level #17571

bclozel opened this issue Jul 18, 2019 · 0 comments
Assignees
@bclozel
Labels
type: enhancement A general enhancement
Milestone
2.2.0.RC1

Comments

@bclozel
Copy link
Member

bclozel commented Jul 18, 2019 •
edited
Loading

As of spring-projects/spring-framework#23314, Spring Messaging is configuring the RouteMatcher at the RSocketStrategies level. We should now configure a PathPatternRouteMatcher implementation there if it is available on classpath (and move that from the RSocketMessagingAutoConfiguration).
@bclozel bclozel added the type: enhancement A general enhancement label Jul 18, 2019
@bclozel bclozel added this to the 2.2.0.M5 milestone Jul 18, 2019
@bclozel bclozel self-assigned this Jul 18, 2019
@bclozel bclozel removed this from the 2.2.0.M5 milestone Jul 18, 2019
@bclozel bclozel added the status: on-hold We can't start working on this issue yet label Jul 18, 2019
@bclozel bclozel added this to the 2.2.x milestone Jul 18, 2019
@bclozel bclozel changed the title Let Spring Framework configure PathPatternRouteMatcher in RSocket support Configure PathPatternRouteMatcher at the RSocketStrategies level Sep 20, 2019
@bclozel bclozel removed the status: on-hold We can't start working on this issue yet label Sep 20, 2019
@bclozel bclozel modified the milestones: 2.2.x, 2.2.0, 2.2.0.RC1 Sep 20, 2019
pull bot pushed a commit to scope-demo/spring-boot that referenced this issue Sep 20, 2019
@bclozel @pull
Configure RouteMatcher at the RSocketStrategies level
1d51f86 
After a change in Spring Framework (see
spring-projects/spring-framework#23314), the `RouteMatcher` to be used
with the RSocket infrastructure is configured on the `RSocketStrategies`
directly.

This commit moves the auto-configuration of the
`PathPatternRouteMatcher` from the message handling parts to the RSocket
strategy one.

Closes spring-projectsgh-17571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.2.0.RC1
Development

No branches or pull requests
1 participant
@bclozel