Skip to content

Consider a better default for JSR-310 Jackson rendering #11079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odrotbohm opened this issue Nov 19, 2017 · 4 comments
Closed

Consider a better default for JSR-310 Jackson rendering #11079

odrotbohm opened this issue Nov 19, 2017 · 4 comments
Assignees
@philwebb
Labels
type: enhancement A general enhancement
Milestone
2.0.0.M7

Comments

@odrotbohm
Copy link
Member

Although Boot makes it quite easy to render JSR-310 dates as ISO-8601 strings, it still requires flipping spring.jackson.serialization.write-dates-as-timestamps to false (see this article for all steps needed).

Maybe 2.0 is the chance to flip the default to false in the first place, and align with the set of better defaults that Boot' Jackson has already implemented (e.g. ignoring unknown properties by default).
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 19, 2017
@MichaelZett
Copy link

Absolutely.

@philwebb philwebb added for: team-attention An issue we'd like other members of the team to review priority: normal type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 19, 2017
@wilkinsona
Copy link
Member

This ties into #10976. Without the change proposed here, #10976 will only really achieve part of its goal. +1 from me for flipping the default for write-dates-as-timestamps.

@philwebb philwebb added this to the 2.0.0.M7 milestone Nov 20, 2017
@philwebb philwebb self-assigned this Nov 20, 2017
@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Nov 20, 2017
@wtatum
Copy link

wtatum commented Nov 22, 2017

+1. I think this is definitely consistent with the "batteries" included idea of spring-boot default/auto config.

bclozel added a commit to bclozel/s1p2017-demo that referenced this issue Dec 21, 2017
@bclozel
Upgrade to Spring Boot 2.0.0.M7
89a041c 
This commit updates the applications to Spring Boot 2.0.0.M7.

One small change is required in the JS client. Since in
spring-projects/spring-boot#11079 the Jackson serialization format
for dates has been flipped, the client needs to parse the date instead
of just processing it as raw EPOCH time.
@bclozel bclozel mentioned this issue Dec 21, 2017
Merged
@zhanhb
Copy link
Contributor

zhanhb commented Feb 3, 2018

Nothing was mentioned in the document.
https://docs.spring.io/spring-boot/docs/2.0.0.RC1/reference/htmlsingle

@philwebb philwebb mentioned this issue Feb 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.0.0.M7
Development

No branches or pull requests
7 participants
@odrotbohm @philwebb @wilkinsona @zhanhb @wtatum @MichaelZett @spring-projects-issues