BATCH-2651: Obvious Fix: ChunkMessageChannelWriter.waitForResults aborts to early #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after maxWaitTimout replies i.s.o. time outs.
|
@ystavanl Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@ystavanl Thank you for signing the Contributor License Agreement! |
fmbenhassine
added
in: integration
status: waiting-for-triage
fmbenhassine
added
pr-for: enhancement
and removed
pr-for: bug
status: waiting-for-triage
|
As mentioned in #952 (comment), this will be closed in favour of opening the Thank you for your contribution anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChunkMessageChannelWriter will only wait for maximal maxWaitTimeouts replies, even when there are more expected. This fix (including a unit test to fix it) changes behaviour so it will read all replies until maxWaitTimeouts consecutive timeouts are encountered.
So for each reply received, the timeout counter is reset to zero.