Skip to content

Auto-detect the class/interface to be mocked #4426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class JobParametersBuilderTests {
@BeforeEach
void initialize() {
this.job = new SimpleJob("simpleJob");
this.jobExplorer = mock(JobExplorer.class);
this.jobExplorer = mock();
this.jobInstanceList = new ArrayList<>(1);
this.jobExecutionList = new ArrayList<>(1);
this.parametersBuilder = new JobParametersBuilder(this.jobExplorer);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public static class JobConfigurationWithoutTransactionManager {

@Bean
public DataSource dataSource() {
return Mockito.mock(DataSource.class);
return Mockito.mock();
}

}
Expand All @@ -190,27 +190,27 @@ public static class JobConfigurationWithUserDefinedInfrastructureBeans {

@Bean
public JobRepository jobRepository() {
return Mockito.mock(JobRepository.class);
return Mockito.mock();
}

@Bean
public JobExplorer jobExplorer() {
return Mockito.mock(JobExplorer.class);
return Mockito.mock();
}

@Bean
public JobLauncher jobLauncher() {
return Mockito.mock(JobLauncher.class);
return Mockito.mock();
}

@Bean
public JobRegistry jobRegistry() {
return Mockito.mock(JobRegistry.class);
return Mockito.mock();
}

@Bean
public JobOperator jobOperator() {
return Mockito.mock(JobOperator.class);
return Mockito.mock();
}

}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ void testStartStopRunning() {
@Test
void testStartStopRunningWithCallback() {

Runnable callback = Mockito.mock(Runnable.class);
Runnable callback = Mockito.mock();
Resource[] jobPaths = new Resource[] {
new ClassPathResource("org/springframework/batch/core/launch/support/2jobs.xml") };
setUpApplicationContextFactories(jobPaths, null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ class JobExplorerFactoryBeanTests {
void setUp() {

factory = new JobExplorerFactoryBean();
DataSource dataSource = mock(DataSource.class);
PlatformTransactionManager transactionManager = mock(PlatformTransactionManager.class);
DataSource dataSource = mock();
PlatformTransactionManager transactionManager = mock();
factory.setDataSource(dataSource);
factory.setTransactionManager(transactionManager);
factory.setTablePrefix(tablePrefix);
Expand All @@ -73,7 +73,7 @@ void testDefaultJdbcOperations() throws Exception {
@Test
void testCustomJdbcOperations() throws Exception {

JdbcOperations customJdbcOperations = mock(JdbcOperations.class);
JdbcOperations customJdbcOperations = mock();
factory.setJdbcOperations(customJdbcOperations);
factory.afterPropertiesSet();
assertEquals(customJdbcOperations, ReflectionTestUtils.getField(factory, "jdbcOperations"));
Expand Down Expand Up @@ -111,7 +111,7 @@ void testCreateExplorer() throws Exception {
@Test
public void testCustomTransactionAttributesSource() throws Exception {
// given
TransactionAttributeSource transactionAttributeSource = Mockito.mock(TransactionAttributeSource.class);
TransactionAttributeSource transactionAttributeSource = Mockito.mock();
this.factory.setTransactionAttributeSource(transactionAttributeSource);
this.factory.afterPropertiesSet();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ class SimpleJobExplorerTests {
@BeforeEach
void setUp() {

jobExecutionDao = mock(JobExecutionDao.class);
jobInstanceDao = mock(JobInstanceDao.class);
stepExecutionDao = mock(StepExecutionDao.class);
ecDao = mock(ExecutionContextDao.class);
jobExecutionDao = mock();
jobInstanceDao = mock();
stepExecutionDao = mock();
ecDao = mock();

jobExplorer = new SimpleJobExplorer(jobInstanceDao, jobExecutionDao, stepExecutionDao, ecDao);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,15 @@ void testValidatorsCanNotBeEmpty() {

@Test
void testDelegateIsInvoked() throws JobParametersInvalidException {
JobParametersValidator validator = mock(JobParametersValidator.class);
JobParametersValidator validator = mock();
validator.validate(parameters);
compositeJobParametersValidator.setValidators(Arrays.asList(validator));
compositeJobParametersValidator.validate(parameters);
}

@Test
void testDelegatesAreInvoked() throws JobParametersInvalidException {
JobParametersValidator validator = mock(JobParametersValidator.class);
JobParametersValidator validator = mock();
validator.validate(parameters);
validator.validate(parameters);
compositeJobParametersValidator.setValidators(Arrays.asList(validator, validator));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ void testRestart() throws Exception {
void testInterruptWithListener() {
step1.setProcessException(new JobInterruptedException("job interrupted!"));

JobExecutionListener listener = mock(JobExecutionListener.class);
JobExecutionListener listener = mock();
listener.beforeJob(jobExecution);
listener.afterJob(jobExecution);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ class SplitStateTests {
void testBasicHandling() throws Exception {

Collection<Flow> flows = new ArrayList<>();
Flow flow1 = mock(Flow.class);
Flow flow2 = mock(Flow.class);
Flow flow1 = mock();
Flow flow2 = mock();
flows.add(flow1);
flows.add(flow2);

Expand All @@ -61,8 +61,8 @@ void testBasicHandling() throws Exception {
@Test
void testConcurrentHandling() throws Exception {

Flow flow1 = mock(Flow.class);
Flow flow2 = mock(Flow.class);
Flow flow1 = mock();
Flow flow2 = mock();

SplitState state = new SplitState(Arrays.asList(flow1, flow2), "foo");
state.setTaskExecutor(new SimpleAsyncTaskExecutor());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public void execute(JobExecution execution) {
void setUp() {

jobLauncher = new TaskExecutorJobLauncher();
jobRepository = mock(JobRepository.class);
jobRepository = mock();
jobLauncher.setJobRepository(jobRepository);

}
Expand Down Expand Up @@ -265,13 +265,13 @@ void testRunStepStatusStopping() {

private void testRestartStepExecutionInvalidStatus(BatchStatus status) throws Exception {
String jobName = "test_job";
JobRepository jobRepository = mock(JobRepository.class);
JobRepository jobRepository = mock();
JobParameters parameters = new JobParametersBuilder().addLong("runtime", System.currentTimeMillis())
.toJobParameters();
JobExecution jobExecution = mock(JobExecution.class);
Job job = mock(Job.class);
JobParametersValidator validator = mock(JobParametersValidator.class);
StepExecution stepExecution = mock(StepExecution.class);
JobExecution jobExecution = mock();
Job job = mock();
JobParametersValidator validator = mock();
StepExecution stepExecution = mock();

when(job.getName()).thenReturn(jobName);
when(job.isRestartable()).thenReturn(true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
*/
class DataFieldMaxValueJobParametersIncrementerTests {

private final DataFieldMaxValueIncrementer incrementer = mock(DataFieldMaxValueIncrementer.class);
private final DataFieldMaxValueIncrementer incrementer = mock();

@Test
void testInvalidKey() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,17 @@
*/
class JobOperatorFactoryBeanTests {

private final PlatformTransactionManager transactionManager = Mockito.mock(PlatformTransactionManager.class);
private final PlatformTransactionManager transactionManager = Mockito.mock();

private final JobRepository jobRepository = Mockito.mock(JobRepository.class);
private final JobRepository jobRepository = Mockito.mock();

private final JobLauncher jobLauncher = Mockito.mock(JobLauncher.class);
private final JobLauncher jobLauncher = Mockito.mock();

private final JobRegistry jobRegistry = Mockito.mock(JobRegistry.class);
private final JobRegistry jobRegistry = Mockito.mock();

private final JobExplorer jobExplorer = Mockito.mock(JobExplorer.class);
private final JobExplorer jobExplorer = Mockito.mock();

private final JobParametersConverter jobParametersConverter = Mockito.mock(JobParametersConverter.class);
private final JobParametersConverter jobParametersConverter = Mockito.mock();

@Test
public void testJobOperatorCreation() throws Exception {
Expand All @@ -76,7 +76,7 @@ public void testJobOperatorCreation() throws Exception {
@Test
public void testCustomTransactionAttributesSource() throws Exception {
// given
TransactionAttributeSource transactionAttributeSource = Mockito.mock(TransactionAttributeSource.class);
TransactionAttributeSource transactionAttributeSource = Mockito.mock();
JobOperatorFactoryBean jobOperatorFactoryBean = new JobOperatorFactoryBean();
jobOperatorFactoryBean.setTransactionManager(this.transactionManager);
jobOperatorFactoryBean.setJobLauncher(this.jobLauncher);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,11 @@ public Set<String> getJobNames() {
jobOperator.setJobLauncher(
(job, jobParameters) -> new JobExecution(new JobInstance(123L, job.getName()), 999L, jobParameters));

jobExplorer = mock(JobExplorer.class);
jobExplorer = mock();

jobOperator.setJobExplorer(jobExplorer);

jobRepository = mock(JobRepository.class);
jobRepository = mock();
jobOperator.setJobRepository(jobRepository);

jobOperator.setJobParametersConverter(new DefaultJobParametersConverter() {
Expand Down Expand Up @@ -288,7 +288,7 @@ public void testGetJobInstanceWithNameAndParameters() {
// given
String jobName = "job";
JobParameters jobParameters = new JobParameters();
JobInstance jobInstance = mock(JobInstance.class);
JobInstance jobInstance = mock();

// when
when(this.jobExplorer.getJobInstance(jobName, jobParameters)).thenReturn(jobInstance);
Expand Down Expand Up @@ -338,14 +338,14 @@ void testStop() throws Exception {
void testStopTasklet() throws Exception {
JobInstance jobInstance = new JobInstance(123L, job.getName());
JobExecution jobExecution = new JobExecution(jobInstance, 111L, jobParameters);
StoppableTasklet tasklet = mock(StoppableTasklet.class);
StoppableTasklet tasklet = mock();
TaskletStep taskletStep = new TaskletStep();
taskletStep.setTasklet(tasklet);
MockJob job = new MockJob();
job.taskletStep = taskletStep;

JobRegistry jobRegistry = mock(JobRegistry.class);
TaskletStep step = mock(TaskletStep.class);
JobRegistry jobRegistry = mock();
TaskletStep step = mock();

when(step.getTasklet()).thenReturn(tasklet);
when(step.getName()).thenReturn("test_job.step1");
Expand All @@ -363,9 +363,9 @@ void testStopTasklet() throws Exception {
void testStopTaskletWhenJobNotRegistered() throws Exception {
JobInstance jobInstance = new JobInstance(123L, job.getName());
JobExecution jobExecution = new JobExecution(jobInstance, 111L, jobParameters);
StoppableTasklet tasklet = mock(StoppableTasklet.class);
JobRegistry jobRegistry = mock(JobRegistry.class);
TaskletStep step = mock(TaskletStep.class);
StoppableTasklet tasklet = mock();
JobRegistry jobRegistry = mock();
TaskletStep step = mock();

when(step.getTasklet()).thenReturn(tasklet);
when(jobRegistry.getJob(job.getName())).thenThrow(new NoSuchJobException("Unable to find job"));
Expand Down Expand Up @@ -399,8 +399,8 @@ public void stop() {
MockJob job = new MockJob();
job.taskletStep = taskletStep;

JobRegistry jobRegistry = mock(JobRegistry.class);
TaskletStep step = mock(TaskletStep.class);
JobRegistry jobRegistry = mock();
TaskletStep step = mock();

when(step.getTasklet()).thenReturn(tasklet);
when(step.getName()).thenReturn("test_job.step1");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class CompositeChunkListenerTests {
@BeforeEach
void setUp() {
chunkContext = new ChunkContext(null);
listener = mock(ChunkListener.class);
listener = mock();
compositeListener = new CompositeChunkListener();
compositeListener.register(listener);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class CompositeItemProcessListenerTests {
@SuppressWarnings("unchecked")
@BeforeEach
void setUp() {
listener = mock(ItemProcessListener.class);
listener = mock();
compositeListener = new CompositeItemProcessListener<>();
compositeListener.register(listener);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class CompositeItemReadListenerTests {
@SuppressWarnings("unchecked")
@BeforeEach
void setUp() {
listener = mock(ItemReadListener.class);
listener = mock();
compositeListener = new CompositeItemReadListener<>();
compositeListener.register(listener);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class CompositeItemWriteListenerTests {
@SuppressWarnings("unchecked")
@BeforeEach
void setUp() {
listener = mock(ItemWriteListener.class);
listener = mock();
compositeListener = new CompositeItemWriteListener<>();
compositeListener.register(listener);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class JdbcExecutionContextDaoTests extends AbstractExecutionContextDaoTests {
@Test
void testNullSerializer() {
JdbcExecutionContextDao jdbcExecutionContextDao = new JdbcExecutionContextDao();
jdbcExecutionContextDao.setJdbcTemplate(mock(JdbcOperations.class));
jdbcExecutionContextDao.setJdbcTemplate(mock());
Exception exception = assertThrows(IllegalArgumentException.class,
() -> jdbcExecutionContextDao.setSerializer(null));
assertEquals("Serializer must not be null", exception.getMessage());
Expand Down
Loading