[WIP] Change timestamps type to OffsetDateTime in Job/Step Execution #4209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to change the data type of startTime, endTime, createTime and lastUpdated in JobExecution and StepExecution to OffsetDateTime, which corresponds to the SQL type TIMESTAMP WITH TIME ZONE. However, the type `TIMESTAMP WITH TIME ZONE` does not seem to be supported by some databases (or their drivers). Here is a quick list of issues related to this change: ### MySQL: ``` Unsupported SQL type: TIMESTAMP_WITH_TIMEZONE ``` At `JdbcJobExecutionDao` (L173 as of 2b258d1) ``` getJdbcTemplate().update(getQuery(SAVE_JOB_EXECUTION), parameters, new int[] { Types.BIGINT, Types.BIGINT, Types.TIMESTAMP_WITH_TIMEZONE, Types.TIMESTAMP_WITH_TIMEZONE, Types.VARCHAR, Types.VARCHAR, Types.VARCHAR, Types.INTEGER, Types.TIMESTAMP_WITH_TIMEZONE, Types.TIMESTAMP_WITH_TIMEZONE }); ``` ### DB2: ``` [jcc][1091][10417][4.31.10] Invalid data conversion: Parameter instance 2022-10-11T15:21:26.905406+02:00 is invalid for the requested conversion. ERRORCODE=-4461, SQLSTATE=42815 ``` ### Derby: ``` ERROR 22005: An attempt was made to get a data value of type 'TIMESTAMP' from a data value of type '2014'. ``` --- Adding custom code for specific DB providers in various DAOs is not an option for the time being. For all these reasons, it was decided to defer the implementation of this feature to future release. Issue spring-projects#1014
This was referenced Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to change the data type of
startTime,endTime,createTimeandlastUpdatedinJobExecutionandStepExecutiontoOffsetDateTime, which corresponds to the SQL typeTIMESTAMP WITH TIME ZONE.However, the type
TIMESTAMP WITH TIME ZONEdoes not seem to be supported by some databases (or their drivers). Here is a quick list of issues related to this change:MySQL:
At
JdbcJobExecutionDao(L173 as of 2b258d1)DB2:
Derby:
Adding custom code for specific DB providers in various DAOs is not an option for the time being.
For all these reasons, it was decided to defer the implementation of this feature to a future release.
Issue #1014