Remove datasource autowiring in AbstractBatchConfiguration #4103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppwfs
reviewed
Apr 29, 2022
...org/springframework/batch/core/configuration/annotation/InlineDataSourceDefinitionTests.java
Outdated
Show resolved
Hide resolved
...ore/configuration/annotation/TransactionManagerConfigurationWithoutBatchConfigurerTests.java
Show resolved
Hide resolved
...main/java/org/springframework/batch/core/configuration/annotation/EnableBatchProcessing.java
Show resolved
Hide resolved
Before this commit, the datasource was autowired in AbstractBatchConfiguration. This was causing context startup failures when no datasource or more than one datasource is present in the context. This commit fixes these failures by looking for the datasource in the application context. This also prevents cyclic configuration dependencies when the datasource bean is defined in the same class where other batch artifacts are autowired. Issue spring-projects#3991
- Restore tests with no datasource - Fix error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the datasource was autowired in
AbstractBatchConfiguration. This was causing context
startup failures when no datasource or more than one
datasource is present in the context.
This commit fixes these failures by looking for the
datasource in the application context. This also
prevents cyclic configuration dependencies when
the datasource bean is defined in the same class where
other batch artifacts are autowired.
Issue #3991