Skip to content

String array command with SystemCommandTasklet #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

philippe-tr
Copy link

Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest master branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

For more details, please check the contributor guide.
Thank you upfront!

Philippe Truche and others added 5 commits May 26, 2021 08:13
setCommand now supports passing in an array of strings. When a single
string is supplied, it is tokenized by the Runtime#exec method. When an
array of strings is supplied, the array is supplied as is to the
Runtime#exec method in which case no tokenization takes place.

Resolves spring-projects#752
Add EPUB output and make all four output formats have links to one another,
to enable discoverability and accessibility (for the folks who need a
particular format to help them read the document).
@fmbenhassine
Copy link
Contributor

@philippe-tr Thank you for your PR! Could you please rebase it on the latest main branch? It would be easier for us to only review the changes related to the PR. Thank you upfront.

@fmbenhassine fmbenhassine added the status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter label Aug 5, 2021
fmbenhassine and others added 5 commits August 5, 2021 21:14
setCommand now supports passing in an array of strings. When a single
string is supplied, it is tokenized by the Runtime#exec method. When an
array of strings is supplied, the array is supplied as is to the
Runtime#exec method in which case no tokenization takes place.

Resolves spring-projects#752
@philippe-tr
Copy link
Author

PR updated to latest main.

@fmbenhassine fmbenhassine removed the status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter label Aug 18, 2021
@philippe-tr
Copy link
Author

Hi. Will this make into 4.2.8 or 4.3.4, or 5.0.0?

@fmbenhassine
Copy link
Contributor

This is better merged in v5 along with #3972.

As a side note, it seems that you did a merge and not a rebase. I will try to take care of this when tackling this PR.

@fmbenhassine fmbenhassine added this to the 5.0.0 milestone Sep 2, 2021
@philippe-tr
Copy link
Author

@benas Thanks for handling for correcting my merge to a rebase. I got tripped up with the upstream, forked, and local repos. I'll be more careful next time.

@fmbenhassine fmbenhassine changed the title Batch 2863 String array command with SystemCommandTasklet May 4, 2022
@fmbenhassine fmbenhassine removed this from the 5.0.0 milestone May 4, 2022
fmbenhassine added a commit that referenced this pull request Oct 12, 2022
@fmbenhassine
Copy link
Contributor

Rebased, squashed and merged as 746c919. The feature of passing a single String for the command and its arguments turned out to be confusing, so it was not merged. The way to specify the command and its arguments is through an array of Strings (similar to the ProcessBuilder API), which is less confusing and makes the implementation simpler (see refinement in 26c39cb).

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String array command with SystemCommandTasklet
2 participants