-
Notifications
You must be signed in to change notification settings - Fork 2.4k
String array command with SystemCommandTasklet #3967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
setCommand now supports passing in an array of strings. When a single string is supplied, it is tokenized by the Runtime#exec method. When an array of strings is supplied, the array is supplied as is to the Runtime#exec method in which case no tokenization takes place. Resolves spring-projects#752
Add EPUB output and make all four output formats have links to one another, to enable discoverability and accessibility (for the folks who need a particular format to help them read the document).
@philippe-tr Thank you for your PR! Could you please rebase it on the latest |
setCommand now supports passing in an array of strings. When a single string is supplied, it is tokenized by the Runtime#exec method. When an array of strings is supplied, the array is supplied as is to the Runtime#exec method in which case no tokenization takes place. Resolves spring-projects#752
PR updated to latest main. |
Hi. Will this make into 4.2.8 or 4.3.4, or 5.0.0? |
This is better merged in v5 along with #3972. As a side note, it seems that you did a merge and not a rebase. I will try to take care of this when tackling this PR. |
@benas Thanks for handling for correcting my merge to a rebase. I got tripped up with the upstream, forked, and local repos. I'll be more careful next time. |
Rebased, squashed and merged as 746c919. The feature of passing a single String for the command and its arguments turned out to be confusing, so it was not merged. The way to specify the command and its arguments is through an array of Strings (similar to the Thank you for your contribution! |
Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:
master
branch and squash your commitsFor more details, please check the contributor guide.
Thank you upfront!