Change metrics type from int to long in StepExecution #3845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmbenhassine
force-pushed
the
GH-3650
branch
from
94c9402 to
5c38023
Compare
fmbenhassine
force-pushed
the
GH-3650
branch
from
5c38023 to
07933a7
Compare
|
Updated and merged as 327160a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR is for #3650 . This work, which is still in progress, has been done to evaluate the impact of the change requested in #3650: change type of metrics from
inttolonginStepExecution. As shown here, many related public APIs are impacted likeStepContribution,SkipPolicy, etc and we need to make sure all changes are still conform to JSR-352 (fortunately, the return type ofjavax.batch.runtime.Metric#getValueislong).