Skip to content

Use spring-boot-starter-parent in spring-batch-elasticsearch #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spring-batch-elasticsearch/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.flattened-pom.xml
102 changes: 66 additions & 36 deletions spring-batch-elasticsearch/pom.xml
Original file line number Diff line number Diff line change
@@ -1,62 +1,92 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>1.5.22.RELEASE</version>
Copy link
Collaborator Author

@scordio scordio Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the latest 1.5 available.

Moving to a higher major version requires refactoring of the item reader and writer due to breaking changes, which would be beyond the scope of this PR.

<relativePath/>
</parent>

<groupId>org.springframework.batch.extensions</groupId>
<artifactId>spring-batch-elasticsearch</artifactId>
<version>0.1.0-SNAPSHOT</version>

<name>Spring Batch Elasticsearch</name>
<description>Spring Batch extension for Elasticsearch</description>
<url>https://github.com/spring-projects/spring-batch-extensions/tree/main/spring-batch-elasticsearch</url>
<inceptionYear>2014</inceptionYear>
<licenses>
<license>
<name>Apache-2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
<distribution>repo</distribution>
</license>
</licenses>

<scm>
<url>https://github.com/spring-projects/spring-batch-extensions/tree/main/spring-batch-elasticsearch</url>
</scm>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<java.version>1.8</java.version>
<spring-batch.version>3.0.10.RELEASE</spring-batch.version>
<spring-data-elasticsearch.version>1.0.1.RELEASE</spring-data-elasticsearch.version>
<mockito.verion>1.9.5</mockito.verion>
<junit.verion>4.13.1</junit.verion>
<!-- Dependency versions overriding -->
<junit.version>4.13.1</junit.version>
</properties>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>2.5.1</version>
<configuration>
<source>${java.version}</source>
<target>${java.version}</target>
</configuration>
</plugin>
</plugins>
</build>

<dependencies>

<!-- Compile -->
<dependency>
<groupId>org.springframework.batch</groupId>
<artifactId>spring-batch-core</artifactId>
<version>${spring-batch.version}</version>
</dependency>

<dependency>
<groupId>org.springframework.data</groupId>
<artifactId>spring-data-elasticsearch</artifactId>
<version>${spring-data-elasticsearch.version}</version>
</dependency>

<!-- Test -->
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-all</artifactId>
<version>${mockito.verion}</version>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>${junit.verion}</version>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>

</dependencies>

</project>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>flatten-maven-plugin</artifactId>
<version>1.6.0</version>
<executions>
<execution>
<id>flatten</id>
<phase>process-resources</phase>
<goals>
<goal>flatten</goal>
</goals>
<configuration>
<flattenMode>ossrh</flattenMode>
<pomElements>
<developers>remove</developers> <!-- FIXME remove once the developers are defined -->
Copy link
Collaborator Author

@scordio scordio Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fmbenhassine, I understand from #166 (comment) that @hpoettker will maintain this module.

Since I couldn't add their handle for review, I assume the onboarding is not complete yet.

Therefore, I haven't added any developers section to the POM and added this parameter to prevent pulling the ones defined in the spring-boot-starter-parent.

<profiles>remove</profiles>
</pomElements>
</configuration>
</execution>
<execution>
<id>flatten-clean</id>
<phase>clean</phase>
<goals>
<goal>clean</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>