Skip to content

Upgrade to Spring Batch 5 #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdeinum opened this issue Feb 27, 2023 · 5 comments
Closed

Upgrade to Spring Batch 5 #111

mdeinum opened this issue Feb 27, 2023 · 5 comments
Labels
module: spring-batch-excel type: dependency-update Pull requests that update a dependency file

Comments

@mdeinum
Copy link
Collaborator

mdeinum commented Feb 27, 2023

Spring Batch 5 has been released some time ago, it is time to release a version that is compatible with Spring Batch 5.

@mdeinum mdeinum added type: dependency-update Pull requests that update a dependency file module: spring-batch-excel labels Feb 27, 2023
@mdeinum mdeinum added this to the spring-batch-excel-0.2 milestone Feb 27, 2023
@krish300
Copy link

@mdeinum I am trying to upgrade one of my spring-boot projects to spring-boot-3.1.3. I have spring-batch-excel-0.1.1 as dependency. May I know if you have any plans to do this upgrade in near future

@mdeinum
Copy link
Collaborator Author

mdeinum commented Sep 19, 2023

Thanks for your comments and usage of this library. I'm currently a bit swamped in other work. So a PR is welcome if you have the time. As there is no real changes in the javax -> jakarta namespace for this I expect it to be a fairly straightforward upgrade (maybe some method signatures need to change).

mdeinum added a commit to mdeinum/spring-batch-extensions that referenced this issue Sep 19, 2023
mdeinum added a commit to mdeinum/spring-batch-extensions that referenced this issue Sep 19, 2023
@mdeinum
Copy link
Collaborator Author

mdeinum commented Sep 19, 2023

I did some quick tests and the project seems to work without changes with both Java17 and Spring Batch 5. So there should nothing be preventing you from upgrading (which is probably also the reason I didn't create a dedicated version for Spring Batch 5, as it just works (tm) ).

I do have a branch in my own repository (https://github.com/mdeinum/spring-batch-extensions/tree/spring-batch-excel-batch5) which you can checkout. The only things changed there are the dependencies and some build related artifacts. The code has remained unchanged.

So in short it should work fine with Spring Batch 5, JDK17 and Apache POI 5.2.3 (the latest version). At least according to the testsuite we have in place.

@krish300
Copy link

You are right. Works well with "Spring Batch 5, JDK17 and Apache POI 5.2.3". Thanks for the prompt response and all the amazing work you do.

btw, do you think I can still PR or you will PR the changes you did in your repo. I never contributed before. :)

@mdeinum
Copy link
Collaborator Author

mdeinum commented Sep 21, 2023

Well as it works we don't really need a PR. There are some things in that PR that I will move to main (upgrades to plugins and how things are managed).

For the compatibility I'll update the documentation to state that it works with Spring Batch 4.3, 5.0 (and I suspect also with 5.1 which is upcoming).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: spring-batch-excel type: dependency-update Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants