Skip to content

Fix/958 fix build with windows #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Nov 20, 2023
Merged

Fix/958 fix build with windows #969

merged 19 commits into from
Nov 20, 2023

Conversation

fabapp2
Copy link
Contributor

@fabapp2 fabapp2 commented Oct 11, 2023 •
edited
Loading

  • Build runs under Windows
  • All tests green
  • Shell application works
  • Spring Boot 3 Upgrade Report app works

Changes

  • Change line endings to sue \n and adjust string comparisons in tests
  • Fix GH action
  • Add new method get...Path() to ProjectResource

closes #958

@fabapp2 fabapp2 linked an issue Oct 11, 2023 that may be closed by this pull request
Fix build with Windows #958
Closed
@fabapp2 fabapp2 self-assigned this Oct 11, 2023
@fabapp2 fabapp2 mentioned this pull request Oct 11, 2023
Merged
@ammachado @fabapp2
Windows path fixes (#965)
f506ef6 
Enhancements to #958

---------

Co-authored-by: Adriano Machado <[email protected]>
Co-authored-by: Fabian Krüger <[email protected]>
Co-authored-by: Adriano Machado <[email protected]>
@ammachado ammachado mentioned this pull request Nov 8, 2023
Closed
@fabapp2 fabapp2 marked this pull request as ready for review November 15, 2023 21:14
@fabapp2 fabapp2 force-pushed the fix/958-fix-build-with-windows branch from e151ab8 to 04b30dc Compare November 20, 2023 21:11
@fabapp2 fabapp2 added the type: bug Something isn't working label Nov 20, 2023
@fabapp2 fabapp2 merged commit a3a5591 into main Nov 20, 2023
@fabapp2 fabapp2 deleted the fix/958-fix-build-with-windows branch November 20, 2023 23:03
@ammachado ammachado mentioned this pull request Nov 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabapp2 fabapp2

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix build with Windows
2 participants
@fabapp2 @ammachado